Merge witnet ethers - #481
Merged
Merged
Conversation
Tommytrg
reviewed
Nov 6, 2025
| module.exports = async function (truffleDeployer, network, [,,, master]) { | ||
| const addresses = await utils.readJsonFromFile("./migrations/addresses.json") | ||
| if (!addresses[network]) addresses[network] = {} | ||
| module.exports = async (truffleDeployer, network, [, master]) => { |
Contributor
There was a problem hiding this comment.
why are we using now the 2nd account instead of 4th?
Collaborator
Author
There was a problem hiding this comment.
Gateway's private keys in host where contracts get deployed have been reordered.
| console.info(` - Transaction: ${receipt.hash}`) | ||
| console.info( | ||
| ` - Tx. gas price: ${ | ||
| receipt.gasPrice < 10 ** 9 |
Contributor
There was a problem hiding this comment.
I think receipt.gasPrice is a BigInt and that's why we are using Number(receipt.gasPrice) below.
Suggested change
| receipt.gasPrice < 10 ** 9 | |
| receipt.gasPrice < BigInt(10 ** 9) |
| "promise-poller": "^1.9.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@biomejs/biome": "^2.2.6", |
| "truffle-flattener": "^1.6.0", | ||
| "truffle-plugin-verify": "^0.6.7", | ||
| "typescript": "^5.9.3", | ||
| "utf-8-validate": "^5.0.2", |
Contributor
There was a problem hiding this comment.
Are we using the following dependencies?
- utf-8-validate
- truffle-flattener
- truffle-assertions
- custom-error-test-helper
- @types/json-bigint
- json-bigint
- axios
| continue | ||
| } | ||
|
|
||
| let _targetAddr = target.addr |
Contributor
There was a problem hiding this comment.
We are not using _targetAddr
Suggested change
| let _targetAddr = target.addr |
| ) | ||
|
|
||
| if (target.impl === impl) { | ||
| _targetAddr = await determineTargetAddr( |
Contributor
There was a problem hiding this comment.
Suggested change
| _targetAddr = await determineTargetAddr( | |
| await determineTargetAddr( |
| @@ -0,0 +1,204 @@ | |||
| # Wit/Oracle Solidity Framework -- Contracts, SDK and CLI tools for EVM-compatible chains | |||
Contributor
There was a problem hiding this comment.
Is this draft ready to review? Should be replacing README.md?
Collaborator
Author
There was a problem hiding this comment.
Sorry, not ready yet.
Tommytrg
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.