Add ToolActivatedEvent and ToolCancelEvent interfaces - #146
Closed
beaufortfrancois wants to merge 4 commits into
Closed
Add ToolActivatedEvent and ToolCancelEvent interfaces#146beaufortfrancois wants to merge 4 commits into
beaufortfrancois wants to merge 4 commits into
Conversation
beaufortfrancois
marked this pull request as draft
March 19, 2026 08:44
bwalderman
requested changes
Mar 19, 2026
| }; | ||
|
|
||
| dictionary ToolCancelEventInit : EventInit { | ||
| DOMString toolName = ""; |
Collaborator
There was a problem hiding this comment.
Looking at this interface, I'm seeing a potential problem with multiple agents and concurrent activations of the same tool. Which one should be cancelled if all we know is the tool name? I'll comment on the issue.
Collaborator
Author
|
@domfarolino Now that #164 has been merged, I guess another one will follow so that I can plug this PR to tool execution. Is that right? |
Collaborator
Author
|
FYI I've rebased this PR because of conflicts |
beaufortfrancois
force-pushed
the
events
branch
from
August 6, 2026 09:32
9f30276 to
7dbb2aa
Compare
Collaborator
|
It looks like this closed mistakenly, since it was based off of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #126 (comment), this PR adds new
ToolActivatedEventandToolCancelEventinterfaces.Preview | Diff