Repository navigation
Conversation
Keep the existing Cargo integration test name and feature gates while moving 106 tests into language, ABI, platform and diagnostics modules Extract shared fixture helpers and document the unchanged per-test CI filters Signed-off-by: hiyouwhatsapp <89997383+hiyouwhatsapp@users.noreply.github.com>
…ites Use complete Rust function boundaries so fixtures containing top-level Wave braces remain inside their original tests Signed-off-by: hiyouwhatsapp <89997383+hiyouwhatsapp@users.noreply.github.com>
LunaStev
left a comment
There was a problem hiding this comment.
Reviewed commit ea23c11d46600403dd9901b8256d3b28ace8d22b.
I parsed the original suite and all five destination source files with syn and compared each top-level function's token stream, including attributes/signatures/bodies, by name. Both sides contain exactly 135 functions and 106 tests, with no missing, added or changed function token streams. The shared helpers remain included in the parent module, and the existing workflow filters are substring filters, so the added module prefixes do not by themselves break those selections. This is structural preservation evidence, not a claim that the complete runtime suite was rerun.
Required correction: the existing formatting gate fails
Reproduce from the PR checkout:
cargo +1.89.0 fmt --all -- --check
rustfmt +1.89.0 --edition 2021 --check tests/codegen/support.rsThe entrypoint's module declarations are out of rustfmt's order. The directly checked support file also retains long runs of empty lines between moved helpers (for example after line 154). Both failures were reproduced locally.
Please format the touched files, including the file brought in by include!, and retain the same test bodies, cfg attributes, helper sharing, timeout behavior and Cargo integration target. No additional source/test splitting or production refactor is needed to address this review.
After formatting, verify the 106-test inventory under the normal target configuration and the existing restricted-backend selection commands. I found no separate behavioral change in the moved function bodies.
| ("x86_64-pc-windows-gnu", "x86_64-pc-windows-msvc"), | ||
| ("x86_64-w64-windows-gnu", "x86_64-pc-windows-msvc"), | ||
| ("aarch64-pc-windows-gnu", "aarch64-pc-windows-msvc"), | ||
| ("aarch64-w64-windows-gnu", "aarch64-pc-w |
There was a problem hiding this comment.
[P2] This module order fails cargo +1.89.0 fmt --all -- --check; rustfmt orders these declarations as abi, diagnostics, language, platform. Also run rustfmt directly on the included tests/codegen/support.rs, which has long runs of empty lines. The function-token comparison preserved all 135 functions/106 tests; the requested fix is limited to formatting.
LunaStev
left a comment
There was a problem hiding this comment.
Re-reviewed the exact updated head c6e090a.
The prior formatting requests are resolved, including the include!-loaded support file. A syntax-tree/token comparison preserves all 135 top-level functions and all 106 tests with their attributes, signatures and bodies. The Cargo integration-test target, feature gates and timeout contracts remain intact.
All touched Rust files pass pinned Rust 1.89 formatting. The exact-head PR CI run 41702008113 is completed/success with all 50 checks successful, including native platform and package lanes.
I found no remaining actionable blocker in this patch. The function comparison is structural preservation evidence; native/runtime validation here is supplied by the successful exact-head CI, not a claim of an additional local full-suite rerun.
Fixes #771
The codegen regression file mixed language semantics, target ABI checks, platform tests and diagnostics in more than 7,000 lines
I moved all 106 existing tests into four focused modules and put their shared setup, fixture isolation and run helpers in one support file
Kept the
codegen_regressionsCargo target, individual test names, feature gates and process timeouts intact so the existing CI and release commands still select the same casesAdded a short guide to the new suite layout and the existing test commands
The code and tests are moved without intentional behavior changes
Haven't run the Rust test suite locally, CI still needs to verify the split