Skip to content

fix: unresolvable private-org uses: example in _checks.yml #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yakimoto wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: unresolvable private-org uses: example in _checks.yml #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: foundation checks

# Reusable cross-project gate (the executable half of wave-foundation). Any WAVE repo runs the same
# secret-scan + file-size gate by calling this:
# jobs: { gate: { uses: wave-av/wave-foundation/.github/workflows/checks.yml@master } }
# jobs: { gate: { uses: ./.github/workflows/_checks.yml } }

@cubic-dev-ai cubic-dev-ai Bot Sep 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The example now resolves only in this repo, but the same comment block tells consumers "Any WAVE repo runs the same gate by calling this" and "no copying = no drift." A sibling WAVE repo that copies uses: ./.github/workflows/_checks.yml has no _checks.yml in its own tree, so the reference fails to resolve exactly the way this PR is meant to eliminate (workflow never starts, zero check-runs, no objection). The PR rationale states the text is what consumers copy downstream, so the fix is incomplete for that stated audience. Scope the example to this repo (foundation-gate.yml is the live caller) or explicitly note that each consuming repo must mirror _checks.yml into its own tree, e.g.: "GitHub Actions cannot resolve a private repo's reusable workflow from a public repo, so sibling WAVE repos must mirror _checks.yml locally to run the same gate (see foundation-gate.yml)."

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/_checks.yml, line 5:

<comment>The example now resolves only in this repo, but the same comment block tells consumers "Any WAVE repo runs the same gate by calling this" and "no copying = no drift." A sibling WAVE repo that copies `uses: ./.github/workflows/_checks.yml` has no `_checks.yml` in its own tree, so the reference fails to resolve exactly the way this PR is meant to eliminate (workflow never starts, zero check-runs, no objection). The PR rationale states the text is what consumers copy downstream, so the fix is incomplete for that stated audience. Scope the example to this repo (foundation-gate.yml is the live caller) or explicitly note that each consuming repo must mirror `_checks.yml` into its own tree, e.g.: "GitHub Actions cannot resolve a private repo's reusable workflow from a public repo, so sibling WAVE repos must mirror `_checks.yml` locally to run the same gate (see foundation-gate.yml)."</comment>

<file context>
@@ -2,7 +2,7 @@ name: foundation checks
 # Reusable cross-project gate (the executable half of wave-foundation). Any WAVE repo runs the same
 # secret-scan + file-size gate by calling this:
-#   jobs: { gate: { uses: wave-av/wave-foundation/.github/workflows/checks.yml@master } }
+#   jobs: { gate: { uses: ./.github/workflows/_checks.yml } }
 # One source of truth -> update here, every repo inherits it (no copying = no drift).
 on:
</file context>

# One source of truth -> update here, every repo inherits it (no copying = no drift).
on:
workflow_call:
Expand Down
Loading