Skip to content

Require method: custom for optuna/ax scheduler engines - #141

Open
kmikowicz-wandb wants to merge 1 commit into
masterfrom
devin/1788468723-engine-method-mapping
Open

kmikowicz-wandb wants to merge 1 commit into
masterfrom
devin/1788468723-engine-method-mapping

Conversation

@kmikowicz-wandb

Copy link
Copy Markdown
Contributor

Summary

scheduler.engine: optuna and scheduler.engine: ax were rejected outright by config validation. They are now accepted, but only with method: custom; engine: wandb continues to require method: grid | random | bayes.

_SUPPORTED_METHODS_BY_ENGINE = {
    "wandb": ["grid", "bayes", "random"],
    "optuna": ["custom"],
    "ax": ["custom"],
}

The engine/method mismatch error now lists methods as `method: x` so it matches the wording of the other method: custom errors. Schema description for scheduler updated to document the mapping; tests updated to cover both directions for optuna/ax.

Link to Devin session: https://coreweave.devinenterprise.com/sessions/71a11719543544858580ce263664369a
Open in Devin Desktop: https://coreweave.devinenterprise.com/desktop/session/71a11719543544858580ce263664369a?variant=devin
Requested by: @kmikowicz-wandb

@devin-ai-integration

Copy link
Copy Markdown
Contributor
Original prompt from Kaelan

SYSTEM:
<latest_message>
Kaelan Mikowicz (U0AGG225800) [ts=1788468606.980819]: In wandb/sweeps, ensure that for the config, scheduler: engine: ax and optuna require method: custom on the sweep, where engine: wandb requires a method: grid, random, bayes
</latest_message>

=== BEGIN THREAD HISTORY ===
Kaelan Mikowicz (U0AGG225800) [ts=1788468606.980819]: In wandb/sweeps, ensure that for the config, scheduler: engine: ax and optuna require method: custom on the sweep, where engine: wandb requires a method: grid, random, bayes
=== END THREAD HISTORY ===
Channel ID: D0BUDUPMV8U
Thread URL: https://weightsandbiases.slack.com/archives/D0BUDUPMV8U/p1788468606980819?thread_ts=1788468606.980819&amp;cid=D0BUDUPMV8U

The <latest_message> is the message that you should use to guide your goals + task for this session, and you should use the rest of the slack thread as context.
A [ts=...] marker on a Slack message is that message's timestamp. To act on a specific message with the slack tool (e.g. adding an emoji reaction via the reaction command), pass that value as timestamp along with the Channel ID — no extra lookup call is needed.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@kmikowicz-wandb
kmikowicz-wandb marked this pull request as ready for review September 3, 2026 20:54
@kmikowicz-wandb
kmikowicz-wandb requested a review from a team as a code owner September 3, 2026 20:54
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant