Repository navigation
Fix bug in patch merge candidate selection. - #283
Merged
Merged
Conversation
ComputeCandidatePatchMergeGlyphs() was being run on merge init. It aims to record all glyphs belonging to non-exclusive patches as candidates for patch merging. However, merges after the initial setup can move some of those glyphs into exclusive patches, which in turn leads to patch merge evaluation against exclusive patches. This moves candidate glyph computation to after segment merging is complete and further filters out exclusive conditions during merge evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComputeCandidatePatchMergeGlyphs() was being run on merge init. It aims to record all glyphs belonging to non-exclusive patches as candidates for patch merging. However, merges after the initial setup can move some of those glyphs into exclusive patches, which in turn leads to patch merge evaluation against exclusive patches. This moves candidate glyph computation to after segment merging is complete and further filters out exclusive conditions during merge evaluation.