Repository navigation
Adds brotli arena allocator - #279
Merged
Merged
Conversation
Internally brotli allocates on each instance creation some large memory structures (eg. 32mb hash table). Under the right conditions this can result in high setup cost per instance. Switch brotli's allocator to an arena which re-uses a fixed buffer. Sized at 64mb which should be sufficient for the vast majority of IFT encoder brotli operations. If arena size is exceeded allocation falls back to 'new'. Updates Compiler's usage of TableKeyedDiff to use a shared brotli binary diff instances so the arena gets reused across subsequent diff operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally brotli allocates on each instance creation some large memory structures (eg. 32mb hash table). Under the right conditions this can result in high setup cost per instance. Switch brotli's allocator to an arena which re-uses a fixed buffer. Sized at 256mb which should be sufficient for the vast majority of IFT encoder brotli operations. If arena size is exceeded allocation falls back to 'new'.
Updates Compiler's usage of TableKeyedDiff to use a shared brotli binary diff instances so the arena gets reused across subsequent diff operations.