Repository navigation
Move shared segments into the merge group in which it has the highest probability. - #273
Closed
garretrieger wants to merge 1 commit into
Closed
garretrieger wants to merge 1 commit into
garretrieger wants to merge 1 commit into
Conversation
… probability. Prior behaviour was to exclude any segments that are shared between merge groups from any merging, by removing them from all merge groups. This change instead picks one of the merge groups to move them too, whichever the segment has the highest probability in. This way these shared segments will still participate in merging.
Contributor
Author
|
Batch testing is inprogress to measure the overall impact of this change. |
Contributor
Author
Results show this is largely neutral impact on cost and segmentation time, but causes some large increases in costs in a small number of fonts, so doesn't look to be beneficial over all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior behaviour was to exclude any segments that are shared between merge groups from any merging, by removing them from all merge groups. This change instead picks one of the merge groups to move them too, whichever the segment has the highest probability in. This way these shared segments will still participate in merging.
The tradeoff being made is that merging decisions for the shared segments are made with respect to the cost function of only the one merge group, completely ignoring the other merge groups. The impact of this should be minor overall since with #268 only overall low probability segments will end up shared between multiple merge groups. High probability shared segments will cause the relevant merge groups to be joined.