Skip to content

Use cloudfront backup urls - #344

Merged
robc-vulncheck merged 2 commits into
mainfrom
3859-cloudfront-backup-urls
Sep 22, 2026
Merged

robc-vulncheck merged 2 commits into
mainfrom
3859-cloudfront-backup-urls

Conversation

@robc-vulncheck

Copy link
Copy Markdown
Collaborator

What

/v4/backup/{feed} now returns a url field holding the CloudFront signed URL. The CLI was ignoring it and was downloading the backups directly from s3. This change ensures all backup downloads use CloudFront by default.

### Why?

The api now returns CloudFront as the primary backup URL. v3 already defaulted to this but this PR enables v4 to use CloudFront by default.

(--json still exposes every regional URL)

Testing

  • tested live on prod: both v3 and v4 now resolve to serve.vulncheck.com
  • tests reworked in backup_advisory_test.go, CloudFront case added to TestBackupFilename
  • go test ./... green, golangci-lint clean

@robc-vulncheck
robc-vulncheck merged commit 9413644 into main Sep 22, 2026
12 checks passed
@robc-vulncheck
robc-vulncheck deleted the 3859-cloudfront-backup-urls branch September 22, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants