Skip to content

bug fix for get_mu_and_sigma, IPCA_Params now exposed, contrast curve docstring fix - #732

Open
IainHammond wants to merge 4 commits into
vortex-exoplanet:masterfrom
IainHammond:master
Open

bug fix for get_mu_and_sigma, IPCA_Params now exposed, contrast curve docstring fix#732
IainHammond wants to merge 4 commits into
vortex-exoplanet:masterfrom
IainHammond:master

Conversation

@IainHammond

@IainHammond IainHammond commented Sep 10, 2026

Copy link
Copy Markdown
Contributor
  • Fixed a critical mistake in get_mu_and_sigma where planet separation was used instead of planet theta in the 4D case
  • The IPCA_Params in ipca is now exposed and available for use. This was to fix a bug but I can't remember how I triggered it. Just trust me
  • Fixed some outdated descriptions in the contrast_curve docstring

@codecov-commenter

codecov-commenter commented Sep 10, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.23%. Comparing base (510e7f3) to head (b48166e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/vip_hci/fm/negfc_fmerit.py 0.00% 1 Missing ⚠️
src/vip_hci/greedy/ipca_fullfr.py 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   50.23%   50.23%           
=======================================
  Files          88       88           
  Lines       17089    17089           
=======================================
  Hits         8584     8584           
  Misses       8505     8505           
Flag Coverage Δ
no_objects 49.05% <0.00%> (ø)
objects 60.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants