[andi79h-claude]

🍰 Pullrequest

The custom Professions NPC (custom_professions_npc, CompleteLearnProfession in src/scripts/custom/custom_creatures.cpp) exempts Cooking and First Aid from the two-primary-professions limit but not Fishing. A character that already knows two primary professions gets "You already know two primary professions." when it picks Fishing. Fishing is a secondary skill like the other two, and learning Fishing first and the primary professions afterwards works, so only the order decided. This adds SKILL_FISHING to the exemption.

Proof

• In SkillLine.dbc (5875), Fishing (356), Cooking (185) and First Aid (129) all have category 9, SKILL_CATEGORY_SECONDARY. The primary professions (Blacksmithing 164, Tailoring 197, Engineering 202, Enchanting 333, …) have category 11, SKILL_CATEGORY_PROFESSION.
• The core counts only category 11 as primary: IsPrimaryProfessionSkill in src/game/Spells/SpellMgr.h returns false for any other category, so MaxPrimaryTradeSkill never applies to Fishing anywhere else.

Issues

• None. Reported by a player on our server.

How2Test

• Take a character with two primary professions, for example via .learn all_recipes Engineering and .learn all_recipes Enchanting. Talk to the Professions NPC and pick Fishing.
  • Before: "You already know two primary professions."
  • After: Fishing is learned at max skill, as Cooking and First Aid already are.
• Picking a third primary profession still gets the message.

Todo / Checklist

• None. Not built locally; it is a one-condition change, and SKILL_FISHING is already used in the same file (GossipSelect_ProfessionNPC, case 13).

🤖 Generated with Claude Code