Repository navigation
Dont allow multiple "rolls" for the same player - #3574
Merged
Merged
Conversation
Stoabrogga
pushed a commit
to Stoabrogga/vmangos
that referenced
this pull request
Oct 27, 2026
(cherry picked from commit 4c51bb7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
this prevents a potential exploit from a modified client or likewise. The exploit is based on incrementing loot->totalXXXX multiple times for the same player, thereby locking other players out from rolling.
Proof
Issues
How2Test
Todo / Checklist