Repository navigation
Fix pvp rank requirements to use items - #3564
Merged
Merged
Conversation
Wow patch shouldn't be checked here, only config status.
Contributor
Author
|
is there something you'd like changed? if so lemme know, I'd like to close this branch |
Contributor
|
Was this not a patch change? |
Contributor
Author
|
I had to check and you're correct, it did change. I hadn't previously found evidence of rank requirement to purchase changing, only for equipping. But as it stands, the current logic is flawed; it prevents the config from functioning if patch is higher than X. I can edit to do a proper check for both |
Check wowpatch and config properly
Contributor
Author
|
updated to check for both patch and config properly |
Stoabrogga
pushed a commit
to Stoabrogga/vmangos
that referenced
this pull request
Oct 19, 2026
(cherry picked from commit 82cdde3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wow patch shouldn't be checked here, only config status, and the conditions are reversed.