Repository navigation
Let OpenIdKeyStore load keys over HTTPS only - #36
Merged
Merged
Conversation
ievgeniiskliarenko
force-pushed
the
jwt/https-only-key-store
branch
from
October 5, 2026 12:22
bb95663 to
a89559c
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
HTTP redirects can bypass the HTTPS restriction for both discovery and key retrieval.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds HTTPS-by-default URL validation to OpenIdKeyStore for discovery and key retrieval.
Changes:
- Validates issuer and JWKS URL schemes before requests.
- Adds configurable allowed schemes through
allowSchemes(). - Tests default restrictions and scheme configuration.
| File | Description |
|---|---|
vicephp/Virtue-JWT/tests/JWK/Store/OpenIdKeyStoreTest.php |
Tests URL rejection and configurable schemes. |
vicephp/Virtue-JWT/src/JWK/Store/OpenIdKeyStore.php |
Adds scheme validation and HTTPS defaults. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ievgeniiskliarenko
marked this pull request as ready for review
October 5, 2026 13:13
evmoroz
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.