Repository navigation
Add Scopes to grant resources by scope roles - #34
Closed
ievgeniiskliarenko wants to merge 1 commit into
Closed
ievgeniiskliarenko wants to merge 1 commit into
ievgeniiskliarenko wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Prefixed client names and unknown scopes can still bypass authorization.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds scope-to-role/resource helpers for role-based access control.
Changes:
- Introduces prefixed scope roles and resource grants.
- Adds unit and authorization tests.
| File | Description |
|---|---|
src/Access/Scopes.php |
Implements scope mapping helpers. |
tests/Access/ScopesTest.php |
Tests scope conversion and access behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| */ | ||
| class Scopes | ||
| { | ||
| public const ROLE_PREFIX = 'scope:'; |
Comment on lines
+46
to
+47
| foreach ($scopes as $scope) { | ||
| $roles[self::resource($scope)] = self::asRoles([$scope]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client can get a scope just by having the same name as that scope. virtue-access's
Userautomatically adds its own name to its roles:new User('read-catalog', []); // roles: ['read-catalog']