Repository navigation
Deny resources without roles in RoleBased - #33
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the stated behavior and is adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Updates role-based access control to deny resources with no configured roles.
Changes:
- Requires a non-empty role list before granting access.
- Adds coverage for users and root identities.
| File | Description |
|---|---|
src/Access/GrantsAccess/RoleBased.php |
Enforces denial for missing or empty role mappings. |
tests/Access/GrantsAccess/RoleBasedTest.php |
Tests denial behavior and configured root access. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ievgeniiskliarenko
marked this pull request as ready for review
October 2, 2026 11:05
evmoroz
reviewed
Oct 2, 2026
Comment on lines
+25
to
+27
| $roles = $this->roles[$resource] ?? []; | ||
|
|
||
| return $roles !== [] && $this->identity->hasRole($roles); |
Contributor
There was a problem hiding this comment.
I would suggest additionally to define a "catch all" resource like *, this way the consumer could pick the default behavior. with "deny all" the absolute default case
Contributor
Author
There was a problem hiding this comment.
We can't really restore the old behaviour (it was quite dangerous), but we can have ANY fallback.
evmoroz
approved these changes
Oct 2, 2026
Atomarius
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoleBasedgranted every resource without configured roles, becauseIdentity::hasRole([])is true. It now denies them; configured resources behave as before.Behaviour change, to be released as virtue-access 0.7.0. Payments, croupier and customer each work around this with their own
RoleBased