dev UD

[vertesy]

No description provided.

[vertesy]

@copilot
1 resolve the merge conflicts in this pull request
2 Go through the merge and make sure that we are not introducing any retrograde or regressive change. Also, make sure that we do not introduce problems that have been fixed on the development branch.

[Copilot]

@vertesy I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly.

You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6e50c876d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Remove the undefined asTibble lookup

With the default wRownames = TRUE, every successful SSV read evaluates !asTibble, but read.simple.ssv() neither declares that parameter nor defines the variable. Normal callers therefore get object 'asTibble' not found instead of their data; add the parameter explicitly or retain the previous data-frame conversion behavior.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Create the target directory before validating it

When manual_directory names a directory that does not exist yet, construct.file.path() now stops at its dir.exists(out_dir) assertion, so execution can never reach this recursive dir.create() call. Create the directory before constructing the path, or allow the constructor to return paths under not-yet-created directories.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Preserve positional order when adding make_names

Existing callers that pass manual_file_name as the fifth positional argument now bind that filename to make_names; the subsequent if (make_names) then receives a character value and errors. Add the new option after the existing parameters so the established positional API continues to work.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Preserve positional order when adding gzip

For existing positional calls, the eighth argument previously configured TabColor but now binds to gzip, while every later styling argument is shifted as well. A color string ultimately reaches if (gzip) and causes an error after writing the workbook; append the new option after the existing arguments or otherwise preserve their positions.

Useful? React with 👍 / 👎.

[vertesy]

@claude

CODEX Have found the following issues with the merge. Could you please address them?

1
"Remove the undefined asTibble lookup

With the default wRownames = TRUE, every successful SSV read evaluates !asTibble, but read.simple.ssv() neither declares that parameter nor defines the variable. Normal callers therefore get object 'asTibble' not found instead of their data; add the parameter explicitly or retain the previous data-frame conversion behavior."

2
"Create the target directory before validating it

When manual_directory names a directory that does not exist yet, construct.file.path() now stops at its dir.exists(out_dir) assertion, so execution can never reach this recursive dir.create() call. Create the directory before constructing the path, or allow the constructor to return paths under not-yet-created directories."

3
"Preserve positional order when adding make_names

Existing callers that pass manual_file_name as the fifth positional argument now bind that filename to make_names; the subsequent if (make_names) then receives a character value and errors. Add the new option after the existing parameters so the established positional API continues to work."

4
"Preserve positional order when adding gzip

For existing positional calls, the eighth argument previously configured TabColor but now binds to gzip, while every later styling argument is shifted as well. A color string ultimately reaches if (gzip) and causes an error after writing the workbook; append the new option after the existing arguments or otherwise preserve their positions."

I Understand that this would mean editing the main branch, because we are updating the dev branch.

[claude]

Claude finished @vertesy's task in 2m 48s —— View job

---

Todo list:

• Gather context (read R/ReadWriter.R, PR diff vs origin/dev)
• Fix To Do #1: undefined asTibble lookup in read.simple.ssv()
• Fix Wiki #2: construct.file.path() validates manual_directory before it's created
• Fix Resources #3: make_names param breaks positional args in write.simple.vec()
• Fix Package errors #4: gzip param breaks positional args in write.simple.xlsx()
• Sanity-checked diffs manually (see note below)
• Commit and push to PR branch (main)

Summary

All 4 issues flagged by Codex have been fixed and pushed to main in commit b09a776 (R/ReadWriter.R + the corresponding .Rd files):

1. read.simple.ssv() (R/ReadWriter.R:457-467) — added the missing asTibble = FALSE parameter (matching the sibling read.simple.tsv()/read.simple.csv() functions), fixing the object 'asTibble' not found error on every default (wRownames = TRUE) call.
2. construct.file.path() (R/ReadWriter.R:198-199) — now creates manual_directory recursively (dir.create(out_dir, recursive = TRUE)) before the dir.exists() assertion, instead of only checking it. This lets write.simple.md.table() (and any other caller) target a not-yet-existing output directory.
3. write.simple.vec() (R/ReadWriter.R:719-721) — moved the new make_names argument to the end of the parameter list (after v) so pre-existing positional calls (..., manual_file_name, manual_directory, o, v) keep binding to the correct parameters.
4. write.simple.xlsx() (R/ReadWriter.R:930-944) — moved the new gzip argument to the end of the parameter list (after v) so pre-existing positional calls keep TabColor, HeaderLineColor, etc. bound to their original positions.

Updated the matching .Rd files (man/read.simple.ssv.Rd, man/write.simple.vec.Rd, man/write.simple.xlsx.Rd) by hand to stay in sync, since roxygen2/R is not installed in this sandbox and I could not regenerate docs automatically — please run devtools::document() locally to double check, though the manual edits mirror the source changes exactly.

Note on branch: Per your comment, I pushed directly to main, which is this PR's head branch (PR #28 is main → dev). The earlier Copilot agent declined because main is also the repo's default branch, but per your explicit confirmation this push was intentional and scoped only to these 4 fixes.

Note on testing: I was not able to run R CMD check, devtools::check(), or any R script in this sandbox (no R/Rscript binary available, and shell access outside the repo directory is blocked). The changes are minimal, targeted, and I manually traced each call site to confirm correctness — but please run the package check suite to confirm before merging into dev.
(branch: main)