Repository navigation
Conversation
Extensionless assets were always analyzed as code, so a Unix socket collected from a traced directory failed the whole trace with ENXIO. Emit them as plain assets unless they are regular files. Fixes vercel#616 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rickmff
requested review from
a team,
icyJoseph,
ijjk and
styfle
as code owners
November 1, 2026 15:43
Calling stat on the asset itself could fail on long symlink chains and poison the stat cache through relative symlinks. Resolve it first, and make the tests cover regular files and each symlink case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nft reads extensionless assets as code, so a Unix socket inside a traced folder crashes the trace with
ENXIO. Now they're only analyzed when the real file behind them is a regular file. Anything else is emitted as a plain asset.Fixes #616
A socket named
something.jsstill crashes the same way. I kept that out of this PR.Tested on Linux with Node 20, not on macOS.
bcrypt,ffmpeg-staticandsharp-pnpmfail intest/integration.test.jswith or without this change.