Repository navigation
CombinedField covariant components, CODATA 2022 masses, example extras - #129
Open
rogeriojorge wants to merge 9 commits into
Open
rogeriojorge wants to merge 9 commits into
rogeriojorge wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
|
…t-cleanup # Conflicts: # essos/dynamics.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CombinedFielddid not overrideB_covariant, so it fell back to the summed CartesianBwhileB_contravariantsummed the VMEC-coordinate components;curl_B,curl_b,kappamixed bases. It now sumsB_covariantand takes|B| = sqrt(B_i B^i)(valid in any coordinates). Non-pytree fields such asVmecare kept static in the pytree, soCombinedField(vmec, ...)can be traced at all (before it raised a TypeError under jit).from pyexpat import modelremoved;timestep: float; proton and neutron masses (and mu_0) updated to CODATA 2022 (they were 2018 values under a 2022 label).pip install 'essos[vmex]'declaresvmex[freeb]>=0.11.3(virtual casing; 0.11.3 adds the MgridFieldorderused by trace_particles_vmec_to_wall). pyQSC_JAX cannot be declared (not on PyPI, direct URLs rejected), so the three near-axis examples print the install command and exit 0.Tests:
test_combined_vmec_fields_sum_covariant_and_contravariant_components(fails on main with the jit TypeError; before the AbsB change kappa was off by up to 76%), updated CODATA pins in test_constants. Full suite on office: 289 passed; the 3 failures are missingf90nmlin that env and test_multiobjectives' import error is fixed by #119 — both also on main.Conflicts trivially with #117 (both add
[project.optional-dependencies]).