macOS: archive universal arm64 + x86_64 binaries - #5
Open
maskraven wants to merge 1 commit into
Open
Conversation
CI already installs GLib for both architectures, but xcodebuild archive on Apple Silicon defaults to arm64-only. The published 0.22.1 pkg is therefore unusable on Intel/QEMU guests. Force ARCHS=arm64 x86_64 for Release archives, fail CI unless lipo reports both slices, and allow the GLib lipo script to fall back to a single Homebrew prefix when the other is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The macOS CI job already installs GLib for arm64 (
brew) and x86_64 (Rosetta Homebrew). The Xcodelipophase even merges those static libs.xcodebuild archiveonmacos-latest(Apple Silicon) still compiles arm64-only, so spice-vdagent-0.22.1.pkg cannot run on Intel or QEMU/KVM guests (filereportsMach-O 64-bit executable arm64).What
ARCHS = arm64 x86_64/ONLY_ACTIVE_ARCH = NOlipo -infomust show both slices or the job failspackage_macos.shis unchanged (still needs Developer ID). After this, a signed.pkgfrom the archive is a universal installer.Local check: