[zamarrowski]

Closes out the run on cornercase 0.13.19.

What it does

• design/upstream-gaps.md says where things stand on 2026-11-07. Everything through #680 has landed except #583 and #549 (refiled as #706 and #707) and #584. "What only cornercase's own window can do" becomes what the window cannot do because cornercase lacks it (#700 to #705, #708, #709), and "To remove once these land" keeps only #706 and #707.
• #584, checked in upstream's code at 7f08441f: neither thing it asks is there. The 20 s pace holds only while a check is pending, and window_focus and view-set --visible leave the poll alone. It was not refiled: the row is only late, and the window would need no change.
• The issues are named where they belong: DESIGN.md's index, and the queue, flows, accounts, terminal, notifications, remote, plugins and pull-requests notes. design/machines.md no longer said close and rename lack the flag, so it needed nothing.
• Muted lines: the Plugins sheet's note on another machine (#703), under a signed-out row (#702), under a routine's cleanup box and the orchestrator's agent, model and effort (#704), and in the ⇧⌘K dialog (#705).
• A hunk's Copy uses raw under the same guard as Numbered::own, now shared as selection::own_if_drawn. It does not use the gap lines.
• ask_free falls back to the first window and toasts when there is none, through one ask shared with ask_remove.

git apply needs a file header

git apply refuses a copied hunk as it stands, whatever its content: patch fragment without header. The copy starts at @@, as upstream's does. Adding the header would need /dev/null and rename handling, so it is left out and the design note and changelog say so. Measured on a Makefile hunk copied from the window:

What was applied	Result
The hunk as copied, with git apply	refused: no file header
The hunk as copied, with patch FILE	applies
With --- a/Makefile and +++ b/Makefile above it, with git apply	applies
The same, with four spaces as before this change	patch does not apply
A CRLF file's hunk, with a file header	refused: the lines come without \r
A hunk on a last line with no newline, with a file header	refused: no \ No newline mark

Checked

Live, on cornercase 0.13.19, Linux x86_64 under Xvfb with lavapipe, and a fake ssh between two servers on one box:

• All the lines above, where they show. The #702 line came from a real account list --check, with a fake agent answering auth status as signed out.
• The Plugins note on a window moved to the other server through the dialog.
• ask_free: with the check slowed and the display's focus moved off the window while it ran, the question opened.

Not checked:

• macOS, Windows, or a real sshd.
• A hunk's Copy on a machine's workspace.
• ask_free before this change, to compare.
• The no-window toast, which needs no window at all.

#584's pace was read in the code, not timed on a real merge. fmt, clippy, tests, machete and jscpd (on a copy, 0.21 %) pass.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: usecornercase/cornercase-gpui
• Branch: main
• File: .coderabbit.yaml
• Commit: 01f70bd
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5af24bf4-4253-4fe9-802a-35aa4fccca6c

Commits

Reviewing files that changed from the base of the PR and between 01f70bd and e4d360b.

Files ignored due to path filters: 1

• Cargo.lock is excluded by !**/*.lock, !Cargo.lock

Files selected for processing: 27

• CHANGELOG.md
• Cargo.toml
• DESIGN.md
• design/accounts.md
• design/changes-panel.md
• design/flows.md
• design/notifications.md
• design/plugins.md
• design/pull-requests.md
• design/queue.md
• design/remote.md
• design/terminal.md
• design/upstream-gaps.md
• design/worktrees.md
• src/dialogs/remote.rs
• src/panels/accounts/agents.rs
• src/panels/accounts/data.rs
• src/panels/accounts/data/tests.rs
• src/panels/changes/diff.rs
• src/panels/changes/diff/tests.rs
• src/panels/changes/lines.rs
• src/panels/flows/editor_view.rs
• src/panels/plugins.rs
• src/panels/plugins/tests.rs
• src/panels/queue/form_view.rs
• src/panels/worktrees/actions.rs
• src/ui/selection.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn