Skip to content

Group logins per person and give every paid login its own seat - #98

Merged
Dinuda merged 2 commits into
mainfrom
limits-group-logins
Oct 20, 2026
Merged

Dinuda merged 2 commits into
mainfrom
limits-group-logins

Conversation

@Dinuda

@Dinuda Dinuda commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

A person with several logins for a tool (personal, work, stale placeholders) appeared once per login in the Limits table, so the same person showed up three or four times.

  • One row per person, led by their primary login: the one closest to a limit, then one reporting any window, then a named login, then the most recently seen.
  • Other logins sit behind a "Show N other logins" toggle (aria-expanded) and render as indented sub-rows.
  • "N of M reporting" now counts people, not logins.

Tested with a new component test (one person, three logins, busiest leads, toggle expands); the admin unit and component suites pass and the type-check is clean.

Per-login seats (5c05295)

  • Detected seats are now one per named paid login (a work Team seat and a personal Pro/Max both count), drawn from every active device of the person; seats for logins they no longer have end. Placeholder logins without an email never get a seat while a named login exists. Admin-confirmed seats are untouched.
  • The device-health cron re-derives detected seats per org, so seats created under the old mapping (Team shown as Free) correct themselves.
  • Each person's row leads with the login used most this period.
  • The "Use detected plan" nudge is gone for detected seats; only an admin-assigned seat no login reports gets a note.

New DB tests cover two logins → two seats, sign-out ending a seat, reconcile replacing an old Free seat, and admin seats being left alone.

🤖 Generated with Claude Code

A person with several logins for a tool (personal, work, stale
placeholders) used to appear once per login. The Limits table now shows
one row per person, led by the login closest to a limit (then one
reporting any window, then a named login, then the most recently seen),
with the rest behind a "Show N other logins" toggle. The reporting count
now counts people rather than logins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 20, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

A person can hold several plans for one tool at once (a work Team seat
and a personal Pro or Max), and each is real spend. Detected seats were
one per person (strongest login), and the page flagged every other
login as a mismatch with a "Use detected plan" button that would have
replaced the seat with whichever login reported last.

- Seat sync keeps one detected seat per named paid login, drawn from
  every active device of the person, and ends seats for logins they no
  longer have. Nameless placeholder logins never get a seat while a
  named login exists. Admin-confirmed seats are still left alone.
- The device-health cron re-derives detected seats for every org, so
  seats created under an old plan mapping (e.g. Team shown as Free) are
  corrected without waiting for a device to report a change.
- Each person's Limits row leads with the login they used most this
  period; their other logins and plans sit under the toggle.
- The mismatch nudge and its button are gone for detected seats. Only an
  admin-assigned seat that none of the person's logins report gets a
  note.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Dinuda Dinuda changed the title Group each person's logins into one Limits row Group logins per person and give every paid login its own seat Oct 20, 2026
@Dinuda
Dinuda merged commit 2887d41 into main Oct 20, 2026
2 checks passed
@Dinuda
Dinuda deleted the limits-group-logins branch October 27, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants