Repository navigation
Conversation
The e2e tests gathered the monitors from several places: QEMU came from apt, Firecracker and Cloud Hypervisor from their upstream releases, virtiofsd from an S3 bucket, and Solo5 was built from source. To resolve that, we created monitors-build repository which publishes static builds of all of them, bundled in a single archive per architecture. Therefore, use these archives instead. The workflows still set the version of each monitor, and a new find-monitors-release action looks up the monitors-build release that bundles exactly those versions. The archive extracts to `/opt/urunc`, and the urunc configuration points every monitor there. On pull requests, vm_test checks out the base branch, so it fetches the action from the commit that the workflow itself was loaded from. Since no monitors-build release provides Solo5 v0.9.3, the default Solo5 version moves to v0.12.1. Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com>
✅ Deploy Preview for urunc canceled.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The e2e tests gathered the monitors from several places: QEMU came from apt, Firecracker and Cloud Hypervisor from their upstream releases, virtiofsd from an S3 bucket, and Solo5 was built from source.
To resolve that, we created monitors-build repository which publishes static builds of all of them, bundled in a single archive per architecture. Therefore, use these archives instead.
The workflows still set the version of each monitor, and a new find-monitors-release action looks up the monitors-build release that bundles exactly those versions. The archive extracts to
/opt/urunc, and the urunc configuration points every monitor there.On pull requests, vm_test checks out the base branch, so it fetches the action from the commit that the workflow itself was loaded from.
Since no monitors-build release provides Solo5 v0.9.3, the default Solo5 version moves to v0.12.1.
Related issues
How was this tested?
In the PR CI.
LLM usage
Opus 5.5
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).