Skip to content

Apply w-conf Eslint - #277

Merged
phndiaye merged 11 commits into
masterfrom
edm/pyx-409
Sep 2, 2026
Merged

Apply w-conf Eslint#277
phndiaye merged 11 commits into
masterfrom
edm/pyx-409

Conversation

@Elodie-DeMatteis-Upf

Copy link
Copy Markdown
Contributor

What does this PR do?

Apply w-conf Eslint

Related to : #

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@Elodie-DeMatteis-Upf Elodie-DeMatteis-Upf self-assigned this Aug 31, 2026
@Elodie-DeMatteis-Upf
Elodie-DeMatteis-Upf requested review from a team and phndiaye as code owners August 31, 2026 15:08
@Elodie-DeMatteis-Upf
Elodie-DeMatteis-Upf requested review from OwenCoogan and edouardmisset and removed request for a team August 31, 2026 15:08
@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown

PYX-409

@edouardmisset edouardmisset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to update the node version in package.json (needed for ESLint 10+) to node v20+

  "engines": {
    "node": "20.*"
  },

Comment thread types/global.d.ts Outdated
Comment thread tests/dummy/app/controllers/application.ts Outdated
Comment thread types/global.d.ts Outdated
@phndiaye
phndiaye merged commit 090ebdd into master Sep 2, 2026
5 checks passed
@phndiaye
phndiaye deleted the edm/pyx-409 branch September 2, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants