@unisim/sdk 0.128.1 — pick up the "designed by" colophon - #163
Merged
Merged
Conversation
Moves this app off its old pin so the About dialog actually shows "App designed by James Markey MBE and the UNI-SIM team." The pin edit is not a formality: a caret on a 0.x pins the MINOR, so ^0.127.0 means >=0.127.0 <0.128.0. The seven apps on ^0.127.0 were already not receiving 0.128.0, and nothing published to the 0.128 line would ever have reached them. Every consumer had to be edited by hand or the release reached nobody. Verified before pushing, per app: npm install, typecheck, production build, and a grep for AUTHORSHIP_DESIGNER in the INSTALLED node_modules/@unisim/sdk/dist - resolving the version is not the same as shipping the code. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M49D85H2FcSGrfbTMQsv3o
Deploying universal-pdf with
|
| Latest commit: |
53eb30a
|
| Status: | 🚫 Build failed. |
PDF's main moved while this branch was open: 8650243 bumped the SDK to 0.128.0 "so main typechecks and can deploy again". Both sides edit the same line, hence the conflict. 0.128.1 wins because it is strictly newer AND it is the release that carries the colophon - 0.128.0 was cut from b0f0900 and does not. Taking 0.128.0 here would have fixed the typecheck and still shipped an app with no credit in its About dialog, which is the thing this branch exists for. package-lock.json was REGENERATED by npm, not hand-merged - a lockfile resolved by picking hunks is a lockfile nobody has verified resolves. Re-verified after resolving: installed @unisim/sdk is 0.128.1, AUTHORSHIP_DESIGNER is present in its dist, typecheck and production build both pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M49D85H2FcSGrfbTMQsv3o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves this app onto
@unisim/sdk@^0.128.1so the About dialog actually shows "App designed by James Markey MBE and the UNI·SIM team." One of 15 identical PRs.Why the pin edit isn't a formality
A caret on a
0.xpins the MINOR.^0.127.0means>=0.127.0 <0.128.0— so nothing published to the 0.128 line would ever have reached this app. Every consumer had to be edited by hand or the release reached nobody.Verified per app, before pushing
npm install→typecheck→ productionbuildAUTHORSHIP_DESIGNERin the installednode_modules/@unisim/sdk/dist— resolving a version is not the same as shipping the code15/15 typecheck and build clean. Two apps (this one and Exports) initially failed the build in a sandbox that has no
.env.local; that guard is thrown byvite.config.tson missing Supabase env vars before any app code compiles, so it can't be caused by an SDK version — confirmed by rebuilding both with correctly-shaped stub env vars, which passed.Worth noting the three apps on
^0.122.x(Beam, DIY, PalsPayIn) jumped six minors and all built clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01M49D85H2FcSGrfbTMQsv3o
Generated by Claude Code