Repository navigation
api: Prefer the live deployment over superseded redeploys - #5
Merged
Merged
Conversation
A redeploy created while a build was running could end up as the newest deployment even after the build replaced it when it went live. Service cards then took their status from that superseded redeploy and stayed on "Launching". The last deployment now falls back to the current deployment when the newest one succeeded but isn't the one running. The last successful deployment is now the current deployment when it is still up. Builds that are running or failed still show on top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a redeploy was created while a build was running, it could stay the newest deployment even after the build went live and replaced it. Service cards took their status from that superseded redeploy and stayed on "Launching" even though the service was running.
LastDeploymentnow falls back to the current deployment when the newest deployment succeeded but isn't the one running.LastSuccessfulDeploymentis now the current deployment while it's still up. Otherwise it falls back to the newest successful deployment.TransformServiceEntityinto thelastDeploymentandlastSuccessfulDeploymenthelpers.Testing
Added table tests in
service_response_test.goforTransformServiceEntity. They cover: