fix(cancel): cancel all applicable batch attempts - #454
Merged
Conversation
This was referenced Jul 29, 2026
ubettigole
marked this pull request as ready for review
July 29, 2026 00:40
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 29, 2026 00:40
ubettigole
force-pushed
the
abettigole/cancel_batch_resolution
branch
from
July 31, 2026 01:02
b6fb666 to
78942af
Compare
ubettigole
force-pushed
the
abettigole/cancel_batch_resolution
branch
from
July 31, 2026 06:27
78942af to
fc4115a
Compare
ubettigole
changed the title
behinddwalls
approved these changes
Jul 31, 2026
ubettigole
force-pushed
the
abettigole/cancel_batch_resolution
branch
from
July 31, 2026 22:38
fc4115a to
e055992
Compare
github-merge-queue
Bot
removed this pull request from the merge queue because the pull requests in the stack were not ordered correctly in the queue
Aug 1, 2026
ubettigole
force-pushed
the
abettigole/cancel_batch_resolution
branch
from
August 1, 2026 17:41
e055992 to
c87cc2f
Compare
Use request-to-batch assignments with a legacy all-state fallback and retry while a claimed request's batch is not yet visible. Jira Issues: CODEM-304
ubettigole
force-pushed
the
abettigole/cancel_batch_resolution
branch
from
August 1, 2026 17:54
c87cc2f to
d95ab4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch retries mint new batch IDs, so a request may be associated with multiple batch attempts. Previously, cancellation stopped after finding one matching active batch, which could leave other attempts running.
Update cancellation to find every eligible batch containing the request. Created, Speculating, and already-Cancelling attempts are handed to speculate for cancellation, while Merging and terminal attempts retain their existing outcomes for conclude to reconcile. Creating attempts remain ignored because they have not been published and may not be fully initialized.
Matching batches are processed deterministically, and every cancellation failure is logged and counted while preserving the first error for classification.
Test Plan
Unit tests
Issues
#354