fix(webapp): add hasAdminDisplayAccess to the env param test mock

[1stvamp]

test/envParamRoute.ownership.test.ts fails on main: 3 of its 4 tests throw

Error: [vitest] No "hasAdminDisplayAccess" export is defined on the
"~/services/session.server" mock. Did you forget to return it from "vi.mock"?

#4421 added a hasAdminDisplayAccess(user) call to the env.$envParam loader, and the test's vi.mock of session.server only returns requireUser, so the call blows up. Both changes were green in their own PR and only conflict once merged together, which is why nobody caught it.

The mock now mirrors the real implementation rather than returning a constant, so it stays correct if the test's user fixture is ever varied. No assertions were changed: the tests were right, the mock was stale.

Worth flagging separately: no workflow runs on push to main, so this has been red since #4421 landed without showing up anywhere. Every PR opened since has inherited the failure.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 92562c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The ownership test adds a hasAdminDisplayAccess session-service mock. The mock accepts admin, impersonation, and optional user-viewing state. It grants access to admins or impersonating users when they are not viewing as another user.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely identifies the added hasAdminDisplayAccess mock in the affected webapp test.
Description check	✅ Passed	The description clearly explains the failure, root cause, fix, and testing context, but it omits the template checklist, issue reference, and screenshot section.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/env-param-test-mock

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.