-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(webapp): Themes + contrast settings update #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
ba9f6e7
9ae20e5
42244ad
653cb43
9aadad2
140073d
942c2b1
030b9a5
3f1731f
33562f5
a3a2434
c206e12
3581326
2f294d3
412a385
7a26ca5
26e6972
05a01df
6846079
635c9c7
6d2a357
5f6b7db
b3893a7
5139255
9e8a8d7
ad3668b
e925979
69600b3
d4edb4c
b1dded7
5c372a1
9f4f5e9
ea0a4b2
5e04145
d527796
7c77040
5c7f7af
9f603ae
15e0e5f
4be8159
9bd77e8
5d0cce5
1ed93e7
2b866b8
9c3b077
74f1979
b8b4f2e
465b361
fcc27bc
9233032
046fcda
c17b1cd
b53fbdb
9781651
61931ab
ddae31f
b666663
68a919c
000ccd1
81274f4
6716463
c6de9d4
0dfaec2
a7fb3e3
0ef9d5b
6073943
ceff1c7
69b7274
6513d67
6357c7d
4c12264
fbb55b1
17f5492
9f80186
78ed1e7
66f79b0
dbbe98e
c73b4e7
950688d
ddf3dbb
0da446c
d5373e5
69f9c05
c39adbb
ee0179f
8bbd59a
7948127
945d28f
11e2770
8c75049
ab83648
5e6a6af
d226c31
b387d5e
99a8b08
4b6aa4c
188a211
b1974e0
68340d8
0ab6217
4b56625
4e774a9
374b2e7
a38b1a7
bb38a1b
d22221c
c1ab98f
db3ca46
632bc23
a1b8310
81b45cf
80321c1
44ab5b0
5bc364b
819420b
7b03086
9b6424e
38ad170
91f98a1
3e7d5e3
ff1b3de
0689066
fc2b65f
ffa3b52
ae288da
17d1a7c
7c548ea
3f3c240
1db252c
447a663
c376521
b41d0de
4719b7a
2fada02
8b64da9
48f75c5
b8813ce
d8ce6d4
d52c68a
62f38ae
27172a1
62c3d4f
33a5415
a585dea
57ceb98
76e3062
41bd30c
6b0484e
92c1992
57769c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/sdk": patch | ||
| --- | ||
|
|
||
| Annotate the optional `@ai-sdk/otel` dynamic import with `@vite-ignore` so Vite-based bundlers don't warn about an unanalyzable import. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: feature | ||
| --- | ||
|
|
||
| Adds an opt-in Interface theme setting on the account page behind a feature flag. Choose Dark (the new default), System preference (follows your OS), Light, or the original Classic look, and fine-tune the new themes with a contrast slider. System preference switches automatically when your OS appearance changes. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,72 @@ | ||
| import { type ReactNode } from "react"; | ||
| import blurredDashboardBackgroundMenuTop from "~/assets/images/blurred-dashboard-background-menu-top.jpg"; | ||
| import blurredDashboardBackgroundMenuTopLight from "~/assets/images/blurred-dashboard-background-menu-top-light.jpg"; | ||
| import blurredDashboardBackgroundMenuBottom from "~/assets/images/blurred-dashboard-background-menu-bottom.jpg"; | ||
| import blurredDashboardBackgroundMenuBottomLight from "~/assets/images/blurred-dashboard-background-menu-bottom-light.jpg"; | ||
| import blurredDashboardBackgroundTable from "~/assets/images/blurred-dashboard-background-table.jpg"; | ||
| import blurredDashboardBackgroundTableLight from "~/assets/images/blurred-dashboard-background-table-light.jpg"; | ||
|
|
||
| /* Blurred dashboard screenshots; the -light set is the same artwork with the | ||
| lightness inverted for the light theme. */ | ||
| const BACKDROPS = [ | ||
| { | ||
| images: { | ||
| menuTop: blurredDashboardBackgroundMenuTop, | ||
| menuBottom: blurredDashboardBackgroundMenuBottom, | ||
| table: blurredDashboardBackgroundTable, | ||
| }, | ||
| tableFill: "#101214", | ||
| className: "hidden lg:block light:lg:hidden", | ||
| }, | ||
| { | ||
| images: { | ||
| menuTop: blurredDashboardBackgroundMenuTopLight, | ||
| menuBottom: blurredDashboardBackgroundMenuBottomLight, | ||
| table: blurredDashboardBackgroundTableLight, | ||
| }, | ||
| tableFill: "#f4f5f7", | ||
| className: "hidden light:lg:block", | ||
|
Comment on lines
+19
to
+28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Light/dark backdrop visibility relies on class-order, not specificity The two backdrop layers are distinguished only by Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| }, | ||
| ]; | ||
|
|
||
| export function BackgroundWrapper({ children }: { children: ReactNode }) { | ||
| return ( | ||
| <div className="relative h-full w-full overflow-hidden bg-background-dimmed lg:bg-transparent"> | ||
| <div | ||
| className="absolute left-0 top-0 hidden w-[260px] bg-contain bg-top-left bg-no-repeat lg:block" | ||
| style={{ | ||
| backgroundImage: `url(${blurredDashboardBackgroundMenuTop})`, | ||
| aspectRatio: "auto", | ||
| height: "100vh", | ||
| backgroundSize: "260px auto", | ||
| }} | ||
| /> | ||
| {BACKDROPS.map(({ images, tableFill, className }) => ( | ||
| <div key={tableFill} className={className}> | ||
| <div | ||
| className="absolute left-0 top-0 w-[260px] bg-contain bg-top-left bg-no-repeat" | ||
| style={{ | ||
| backgroundImage: `url(${images.menuTop})`, | ||
| aspectRatio: "auto", | ||
| height: "100vh", | ||
| backgroundSize: "260px auto", | ||
| }} | ||
| /> | ||
|
|
||
| <div | ||
| className="absolute bottom-0 left-0 hidden w-[260px] bg-contain bg-bottom-left bg-no-repeat lg:block" | ||
| style={{ | ||
| backgroundImage: `url(${blurredDashboardBackgroundMenuBottom})`, | ||
| aspectRatio: "auto", | ||
| height: "100vh", | ||
| backgroundSize: "260px auto", | ||
| }} | ||
| /> | ||
| <div | ||
| className="absolute bottom-0 left-0 w-[260px] bg-contain bg-bottom-left bg-no-repeat" | ||
| style={{ | ||
| backgroundImage: `url(${images.menuBottom})`, | ||
| aspectRatio: "auto", | ||
| height: "100vh", | ||
| backgroundSize: "260px auto", | ||
| }} | ||
| /> | ||
|
|
||
| <div | ||
| className="absolute top-0 hidden bg-top-left bg-no-repeat lg:block" | ||
| style={{ | ||
| left: "260px", | ||
| backgroundImage: `url(${blurredDashboardBackgroundTable})`, | ||
| width: "100%", | ||
| height: "100vh", | ||
| backgroundSize: "1200px auto", | ||
| backgroundColor: "#101214", | ||
| }} | ||
| /> | ||
| <div | ||
| className="absolute top-0 bg-top-left bg-no-repeat" | ||
| style={{ | ||
| left: "260px", | ||
| backgroundImage: `url(${images.table})`, | ||
| width: "100%", | ||
| height: "100vh", | ||
| backgroundSize: "1200px auto", | ||
| backgroundColor: tableFill, | ||
| }} | ||
| /> | ||
| </div> | ||
| ))} | ||
|
|
||
| <div className="relative z-10 h-full w-full">{children}</div> | ||
| </div> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the release note user-facing.
Remove “behind a feature flag”; this file is published verbatim, so it should describe the available theme behavior rather than an internal rollout mechanism.
Proposed wording
Based on learnings,
.server-changes/*.mdentries are published verbatim as user release notes and should avoid implementation-oriented details such as feature flags.📝 Committable suggestion
Source: Learnings