Skip to content

Hide the three Windows child processes #683 couldn't see - #769

Merged
shhdwi merged 2 commits into
mainfrom
fix/windows-hide-followup
Nov 8, 2026
Merged

shhdwi merged 2 commits into
mainfrom
fix/windows-hide-followup

Conversation

@shhdwi

@shhdwi shhdwi commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

#683 added windowsHide: true to every git/gh child process and a test that fails if any call is missing it. Three calls landed on main after that PR was opened, so with #683 merged the test fails on main:

  • src/cli-meta.ts npmRun (spawnSync("npm"))
  • src/cloud/share-session.ts whoIAm (git config --global --get)
  • src/notes/pr-reviews.ts revertCommits (git log --grep=^Revert)

This adds the flag to those three. Node ignores the flag outside Windows, so behaviour elsewhere is unchanged.

Checked: test/child-process-windowshide.test.ts fails 1 of 3 on main and passes 3 of 3 here; typecheck clean.

🤖 Generated with Claude Code

Shrish Dwivedi and others added 2 commits November 8, 2026 16:15
src/cli-meta.ts npmRun, src/cloud/share-session.ts whoIAm and
src/notes/pr-reviews.ts revertCommits were added after this PR opened and
failed its own windowsHide scanner test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trailhq-graft

trailhq-graft Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

🌱 graft blast radius

3 areas changed → 1 area can be affected. 3 dependent symbols, depth 2.
Tests: no test reaches Cloud Session Persistence, CLI Metadata, PR Review Notes.
Tag: @anirudhkumar-nanonets — 4 of 4 areas · @Faeeth — CLI Metadata, PR Review Notes

flowchart TB
  A0(("Session Sharing<br/>3 symbols"))
  classDef reached fill:#D9EDF3,stroke:#3AA7C9,stroke-width:1.5px,color:#0E313C;
  class A0 reached;
Loading
Can be affected Symbols Nearest hop Reached from
Session Sharing 3 src/cli.ts:L1-L3312 cli.ts — calls, depth 2 CLI Metadata, Cloud Session Persistence
Who knows this code — 2 people across 4 areas
Area Who knows it
Cloud Session Persistence · changed @anirudhkumar-nanonets — 1 commit, last 2d ago
CLI Metadata · changed @anirudhkumar-nanonets — 3 commits, last 10d ago · @Faeeth — 1 commit, last today
PR Review Notes · changed @anirudhkumar-nanonets — 2 commits, last 17d ago · @Faeeth — 1 commit, last today
Session Sharing · affected @anirudhkumar-nanonets — 68 commits, last yesterday

Ownership is git history over each area's own files, weighted towards recent work (120-day half-life). Merge commits and bots are dropped, and you are dropped from your own PR. A name with no @ has no GitHub handle in its commit email — tag them by hand, or add a .mailmap entry. A suggestion from history, not a CODEOWNERS rule.

All 3 dependent symbols, grouped by area

Session Sharing — 3 symbols in 1 file

  • src/cli.ts:L1-L3312 — cli.ts (calls, depth 2)
    5: * graft/ and a clone has the graph. A workspace parent (≥2 git children)
  • src/cli.ts:L2541-L2589 — shareOneSession (calls, depth 2)
    2545: console.error(sessions.length ? `✗ no session "${pick}" here · ${cmd("graft share-session")} --list shows them` : "✗ no Claude Code sessions for this folder yet");
  • src/cli.ts:L2598-L2671 — shareWholeClaude (calls, depth 2)
    2636: return r.git && !r.key.startsWith("local/") ? r.key : "";
Test signal per changed area — 3 ✗

Reached = a node under a test path has a resolved edge into the changed symbol. It undercounts anything called indirectly — through a CLI, a spawned process or a dynamic import — so read a low ratio as “look here”, never as a coverage gate.

  • ✗ Cloud Session Persistence — 0 of 1 reached · no test file reaches it
    • not reached: git
  • ✗ CLI Metadata — 0 of 1 reached · no test file reaches it
    • not reached: npmRun
  • ✗ PR Review Notes — 0 of 1 reached · no test file reaches it
    • not reached: revertCommits
1 test suite also references this code

1 symbol, kept out of the diagram and the table so they cannot crowd out the areas a reviewer has to look at.

  • test/share-session.test.ts

⚠️ 1 changed file not in the graph (.trail/learnings/2026-11-08-every-new-child-process-must-pass-shrish.md) — no parser claims the extension, or the index predates the file.

graft blast · origin/main...HEAD · depth 2 · 4 changed files

Open the interactive graph → — click an area to see its dependent symbols at file:line.

github-actions Bot added a commit that referenced this pull request Nov 8, 2026
@shhdwi
shhdwi merged commit e29aa36 into main Nov 8, 2026
7 of 8 checks passed
@shhdwi
shhdwi deleted the fix/windows-hide-followup branch November 8, 2026 10:58
github-actions Bot added a commit that referenced this pull request Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant