chore: update dependencies - #2060
Conversation
Updated 88 lockfile packages for Rust 1.88 compatibility, including: - bollard 0.20.2 to 0.21.1 - testcontainers 0.27.3 to 0.28.0 - parse-display 0.9.1 to 0.11.0 - futures 0.3.33 to 0.3.34 - ICU 2.2.0 to 2.3.0 components - rustls 0.23.42 to 0.23.43 - wasm-bindgen 0.2.126 to 0.2.127 Also added bitflags, defmt, jiff, and tower-http transitive packages; removed concurrent-queue, ureq, ureq-proto, and utf8-zero.
1df3b1f to
8630266
Compare
There was a problem hiding this comment.
Pull request overview
This pull request updates the workspace’s locked Rust dependencies (targeting Rust 1.88 compatibility) and refactors a few CI/E2E routines and job-management code to keep Clippy happy after the upgrade. It also adjusts developer workflows so git-hook log output defaults to the repository’s ignored .tmp/ directory and documents preserving cargo update output in dependency-update commits.
Changes:
- Updated
Cargo.lockwith a broad set of dependency version bumps. - Refactored qBittorrent E2E scenario code and job manager logic to reduce cognitive complexity.
- Updated maintenance docs and git hooks to default hook logs to
.tmp/and to preservecargo updateoutput in commit bodies.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.lock |
Updates the lockfile with new dependency versions and some dependency graph reshaping. |
src/bootstrap/jobs/manager.rs |
Extracts job-waiting/logging into helpers to reduce complexity and centralize result logging. |
src/console/ci/qbittorrent_e2e/scenarios/seeder_to_leecher_transfer.rs |
Splits the scenario into arrange/act/assert helper steps for readability and Clippy. |
src/console/ci/qbittorrent_e2e/scenario_steps/qbittorrent/ensure_torrent_is_absent.rs |
Extracts delete/poll steps into helpers to reduce complexity while preserving behavior. |
.github/skills/dev/maintenance/update-dependencies/SKILL.md |
Updates the workflow to store cargo update output under .tmp/ and use it as the commit body. |
.githooks/pre-commit |
Defaults TORRUST_GIT_HOOKS_LOG_DIR to $repo_root/.tmp for installed hooks. |
.githooks/pre-push |
Defaults TORRUST_GIT_HOOKS_LOG_DIR to $repo_root/.tmp for installed hooks. |
Suppressed comments (1)
.github/skills/dev/maintenance/update-dependencies/SKILL.md:79
- This code block uses
tee .tmp/cargo-update.txt, but.tmp/may not exist yet. Create it first to avoid failures when following these steps on a clean workspace.
cargo update 2>&1 | tee .tmp/cargo-update.txt
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2060 +/- ##
===========================================
- Coverage 82.03% 81.97% -0.07%
===========================================
Files 349 349
Lines 24845 24849 +4
Branches 24845 24849 +4
===========================================
- Hits 20382 20370 -12
- Misses 4157 4173 +16
Partials 306 306 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
ACK e1777a9 |
Summary
Cargo.lockwith 88 dependency versions compatible with Rust 1.88.cargo updateoutput in future dependency-update commit messages..tmpdirectory while retainingTORRUST_GIT_HOOKS_LOG_DIRoverrides.Validation