Skip to content

Refresh only the selected HTML preview on Retry - #27

Merged
tnfssc merged 4 commits into
developfrom
t3/product-improvements
Oct 7, 2026
Merged

tnfssc merged 4 commits into
developfrom
t3/product-improvements

Conversation

@tnfssc

@tnfssc tnfssc commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Existing failure-only Retry refetches the selected HTML document and its supported repository resource graph using fresh HTTP requests (cache reload). No browser-wide/origin-wide cache clearing, new permissions, or new controls.
  • Blob Retry skips stale embedded source. PR Retry keeps original base/head commits and leaves other cards and shared metadata work alone.
  • Repository CSS imports, images/fonts, classic scripts, static/literal-dynamic module descendants, and SVG image href/xlink:href participate in fresh resolution. Normal loads retain normal caching.
  • Preserve namespaces/fragments; diagnose unsupported repository external SVG use rather than emitting a data URL Chromium cannot render. Inline symbols and authored external URLs stay intact.
  • Record HTML-reading product direction, UX-first value, implementation decisions, limits, and test evidence in wisdom. Prepare version 0.6.7 for release after merge.

Verification

  • TypeScript compile and diff check.
  • 108 unit tests, 26 extension E2E tests, 3 live GitHub smoke tests passed in the integration worktree.
  • Two focused Retry tests passed again with before/after screenshot comparisons proving modern/legacy SVG images change when fresh bytes are rendered.
  • Stable/debug ZIP construction, package/manifest version checks, and installation smoke from both exact ZIPs passed.
  • Tests cover reload policy, transitive resources, private transport, exact refs, and an unrelated document/card. Playwright routing disables HTTP caching; browser tests prove request policy and rendering, not disk-cache eviction. A unit cache model checks stale/fresh behavior.

Limits

External resources and arbitrary runtime requests keep normal browser behavior. Dedicated full-preview error recovery reloads its already packaged snapshot. Repository external SVG use requires inline symbols or a standalone SVG image; it receives an actionable diagnostic.

Release plan

After CI and review, merge this PR and push v0.6.7 at the merged commit. The release workflow tests/builds the exact stable archive before publishing it.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 12cd5b59-1c00-4e56-a0e6-c8885991de6e
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tnfssc

tnfssc commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Independent review approved the scoped Retry implementation and the rendered SVG refresh regression. Integration validation passed: TypeScript, 108 unit tests, 26 extension E2E tests, 3 live GitHub smoke tests, stable/debug ZIP builds, version checks, and installation smoke from both exact archives. Two focused Retry tests also passed after the final screenshot assertions. Waiting for GitHub CI before merging and tagging the merged commit as v0.6.7.

@tnfssc
tnfssc merged commit 0bf6a0b into develop Oct 7, 2026
8 checks passed
@tnfssc

tnfssc commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

Released v0.6.7 from merged commit 0bf6a0b. The release workflow passed all checks, including installation smoke of the exact published archive. Stable release: https://github.com/tnfssc/github-html-preview/releases/tag/v0.6.7 . Code and wisdom are merged; no worktree edits were made after shipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant