Repository navigation
Conversation
The UUID of a Service Data - 128-bit UUID field is sent in little endian, like addServiceData writes it, but ServiceData read it as big endian and returned the UUID with its bytes reversed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rawAdvertisementPayload.ServiceData read the UUID of a Service Data 128-bit UUID field with NewUUID, which expects big endian. The field is little endian, as addServiceData writes it and as ServiceUUIDs reads 128-bit UUID lists, so the UUID came out with its bytes reversed.
This changes the UUID that the HCI and SoftDevice backends report. Code that compared it with the reversed value will stop matching. Linux and macOS get the UUID from the OS and do not change.
TestCreateAdvertisementPayload now checks the decoded 128-bit UUID. It fails without the fix.
The HCI backend has the same reversal for 128-bit service UUID lists in gap_hci.go. This PR does not touch it.