Modernize WikiMessage: Migrate to SwiftUI and async/await

.github/workflows/ci.yml

@@ -7,10 +7,50 @@ on:
     branches: [master]
 
 jobs:
-  smoke:
-    name: Smoke
-    runs-on: ubuntu-latest
+  build-test:
+    name: Build & Test
+    runs-on: macos-14
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Select Xcode 15
+        uses: maxim-lobanov/setup-xcode@v1
+        with:
+          xcode-version: "15.4"
+
+      - name: List available simulators
+        run: xcrun simctl list devices available
+
+      - name: Cache DerivedData
+        uses: actions/cache@v4
+        with:
+          path: ~/Library/Developer/Xcode/DerivedData
+          key: derived-data-${{ hashFiles('WikiMessage.xcodeproj/project.pbxproj') }}
+          restore-keys: derived-data-
+
+      - name: Build
+        run: |
+          xcodebuild \
+            -project WikiMessage.xcodeproj \
+            -scheme "WikiMessage MessagesExtension" \
+            -destination "platform=iOS Simulator,name=iPhone 15,OS=latest" \
+            -derivedDataPath ~/Library/Developer/Xcode/DerivedData \
+            clean build \
+            CODE_SIGN_IDENTITY="" \
+            CODE_SIGNING_REQUIRED=NO
+
+  lint:
+    name: swift-format
+    runs-on: macos-14
+
     steps:
-      - uses: actions/checkout@v4
-      - name: Confirm CI is wired up
-        run: echo "CI configured. Build and test jobs run from feature-branch workflows."
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install swift-format
+        run: brew install swift-format
+
+      - name: Lint
+        run: swift-format lint --recursive .

.gitignore

@@ -1,7 +1,24 @@
 
-# Carthage related files
-Carthage
+# Swift Package Manager
+.swiftpm/
+
+# Carthage (legacy — no longer used, but Xcode may regenerate artifacts)
 Cartfile.resolved
+Carthage/
+
+# Certificates and private keys — NEVER commit these
+*.p12
+*.cer
+*.mobileprovision
+
+# Xcode workspace generated files
+**/*.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
+
+# Xcode-generated Package.swift inside extension folder
+WikiMessage\ MessagesExtension/Package.swift
+
+# Other generated files
+sources.txt
 
 # macOS stuff
 .DS_Store
@@ -57,12 +74,6 @@ Package.resolved
 #
 # Pods/
 
-# Carthage
-#
-# Add this line if you want to avoid checking in source code from Carthage dependencies.
-Carthage/Checkouts
-
-Carthage/Build
 
 # fastlane
 #

.swift-format

@@ -0,0 +1,56 @@
+{
+  "version": 1,
+  "lineLength": 110,
+  "indentation": {
+    "spaces": 4
+  },
+  "tabWidth": 4,
+  "maximumBlankLines": 1,
+  "respectsExistingLineBreaks": true,
+  "lineBreakBeforeControlFlowKeywords": true,
+  "lineBreakBeforeEachArgument": false,
+  "lineBreakBeforeEachGenericRequirement": false,
+  "prioritizeKeepingFunctionOutputTogether": true,
+  "indentConditionalCompilationBlocks": true,
+  "indentSwitchCaseLabels": false,
+  "fileScopedDeclarationPrivacy": {
+    "accessLevel": "private"
+  },
+  "rules": {
+    "AllPublicDeclarationsHaveDocumentation": false,
+    "AlwaysUseLowerCamelCase": true,
+    "AmbiguousTrailingClosureOverload": true,
+    "BeginDocumentationCommentWithOneLineSummary": false,
+    "DoNotUseSemicolons": true,
+    "DontRepeatTypeInStaticProperties": true,
+    "FileScopedDeclarationPrivacy": true,
+    "FullyIndirectEnum": true,
+    "GroupNumericLiterals": true,
+    "IdentifiersMustBeASCII": true,
+    "NeverForceUnwrap": false,
+    "NeverUseForceTry": true,
+    "NeverUseImplicitlyUnwrappedOptionals": false,
+    "NoAccessLevelOnExtensionDeclaration": true,
+    "NoBlockComments": true,
+    "NoCasesWithOnlyFallthrough": true,
+    "NoEmptyTrailingClosureParentheses": true,
+    "NoLabelsInCasePatterns": true,
+    "NoLeadingUnderscores": false,
+    "NoParensAroundConditions": true,
+    "NoVoidReturnOnFunctionSignature": true,
+    "OmitExplicitReturns": true,
+    "OneCasePerLine": true,
+    "OneVariableDeclarationPerLine": true,
+    "OnlyOneTrailingClosureArgument": true,
+    "OrderedImports": true,
+    "ReturnVoidInsteadOfEmptyTuple": true,
+    "UseEarlyExits": false,
+    "UseLetInEveryBoundCaseVariable": false,
+    "UseShorthandTypeNames": true,
+    "UseSingleLinePropertyGetter": true,
+    "UseSynthesizedInitializer": true,
+    "UseTripleSlashForDocumentationComments": true,
+    "UseWhereClausesInForLoops": false,
+    "ValidateDocumentationComments": false
+  }
+}

README.md

@@ -1,55 +1,85 @@
-# Wikipedia Message
-
-### An iMessages extension for searching, sending, and reading article from Wikipedia
-
----
-
-## Purpose
-
-Wikipedia Message (WikiMessage) is a [MessagesExtension](messages-extension) for Messages in iOS. It allows the user to quickly search for articles on Wikipedia and add them to a conversation. Selected articles are richly formatted in a custom message layout. Receivers can open the linked articles inline from Messages and view a stripped down reader mode of the contents, or choose to view the fully rendered version without leaving Messages. Rich formatting also appears on non-iOS devices (i.e. macOS) and allow the article to open directly inside a browser.
-
-All of that aside, it was mostly a way for me to explore the current state of Swift and discover what a nightmare mobile development is.
-
-## Design
-
-WikiMessage is a [standalone](standalone) Messages App and thus does not come with a "container" (host) application. As such, it's feature set is limited to the [`MessagesExtension`](messages-extension) API subset. While an extension with a container app would be able to do processing within the host application, app processing for a standalone extension is done within the extension code itself.
-
-Luckily WikiMessage's function is simple and straightforward. The basic functionality is as follows:
-
-- Send flow:
-  1. Open a search interface for searching Wikipedia
-  2. Perform real-time fuzzy (more on this later) searches based on user input
-  3. Return list of relevant results
-  4. Allow user to select specific article
-  5. Preview selected article for sending
-  6. Send article
-
-- Receive flow:
-  1. Receive richly formatted message of sent article in conversation
-  2. Select article to open in-line preview
-  3. Browse and read full contents of selected article and provide limited browsing within the rendered interface
-  4. Show fully rendered article page upon request
-  5. Allow opening in other applications
-   (non-iOS) Allow opening of article in default browser
-
-In addition to this basic functionality, the interface should provide additional amounts of information (preview images, subtitles, description text, etc.), at the appropriate steps, so that the user doesn't have to go to another application to find an intended article.
-
-### Wikipedia API
-
-At the heart of WikiMessages is the [Wikipedia API](https://www.mediawiki.org/wiki/API:Main_page), provided by the WikiMedia Foundation. Wikipedia offers a number of different API's to access content. WikiMessages make use of the RESTful API.
-
-**Note**: Although multiple "top level" language Wikipedia's provide a RESTful API, WikiMessages current only uses the API for the English Wikipedia page at [https://en.wikipedia.org/](wikipedia). Multi-language support may be considered in the future.
-
-The mechanics of RESTful APIs will not be dealt with here. Familiarity with these types of APIs and how to query them is assumed.
-
-Wikipedia provides a very useful [sandbox](https://www.mediawiki.org/wiki/Special:ApiSandbox) for testing queries against real data. It is recommended to try any new queries here.
-
-### Step 1: Searching
-
-The primary query to the Wikipedia API is to perform a text based search against article titles based on a given string. This search should return the full list of relevant (more on that later) articles as well as some light metadata on each.
-
-When a user first inputs a search string into the search box, a query is constructed of [url-encoded] elements and sent to the Wikipedia API.
-
-**Components**:
-
-Entering text in the search bar triggers a query to the `action` endpoint of the API. The `searchForArticle` method constructs a basic query using the `action=query` method.
+# WikiMessage
+
+An iMessage extension for searching and sharing Wikipedia articles.
+
+## What it does
+
+Open WikiMessage from the iMessage app drawer, type a query, and tap a result to insert a richly formatted article card into the conversation. Recipients can tap the card to open the article in Safari Reader Mode without leaving Messages.
+
+## Requirements
+
+- Xcode 17 or later
+- iOS 17.0+ deployment target
+- Apple Developer account (team `T5VJ9JRCNB`) for signing
+
+## Building
+
+```bash
+open WikiMessage.xcodeproj
+```
+
+Select the **WikiMessage MessagesExtension** scheme, choose an iOS 17+ simulator, and run. No package fetching or Carthage bootstrap needed — zero third-party dependencies.
+
+To run tests:
+
+```bash
+xcodebuild \
+  -project WikiMessage.xcodeproj \
+  -scheme "WikiMessage MessagesExtension" \
+  -destination "platform=iOS Simulator,name=iPhone 16,OS=latest" \
+  test \
+  CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO
+```
+
+## Architecture
+
+```
+WikiMessage MessagesExtension/
+├── MessagesViewController.swift   # Thin UIHostingController shell
+├── App/
+│   ├── AppModel.swift             # @Observable: presentation style, composer, selected URL
+│   └── RootView.swift             # NavigationStack + .searchable entry point
+├── Features/
+│   ├── Search/
+│   │   ├── SearchModel.swift      # @Observable: query, phase, recent searches
+│   │   ├── SearchResultsList.swift
+│   │   ├── ArticleRow.swift
+│   │   └── RecentSearchesStore.swift
+│   ├── States/
+│   │   ├── LoadingView.swift
+│   │   ├── EmptyResultsView.swift
+│   │   └── ErrorView.swift
+│   └── SafariView.swift           # UIViewControllerRepresentable
+├── Messaging/
+│   ├── MessageComposer.swift      # Protocol + LiveMessageComposer
+│   └── MessageBuilder.swift      # MSMessageTemplateLayout builder
+├── Data/
+│   ├── Article.swift              # Domain model (Sendable, Identifiable, Hashable)
+│   ├── WikipediaService.swift     # actor; search + summary
+│   └── DTOs/
+│       ├── SummaryDTO.swift       # /api/rest_v1/page/summary shape
+│       └── SearchResponseDTO.swift # Wikimedia Core API search shape
+└── Networking/
+    ├── HTTPClient.swift           # actor; URLSession wrapper with shared decoder
+    └── NetworkMonitor.swift       # @Observable NWPathMonitor wrapper
+
+WikiMessageExtensionTests/
+├── Support/MockURLProtocol.swift
+├── Fixtures/{summary_einstein,search_swift}.json
+├── DTOs/{SummaryDTO,SearchResponseDTO}Tests.swift
+├── Services/WikipediaServiceTests.swift
+└── Messaging/MessageBuilderTests.swift
+```
+
+## APIs used
+
+| Purpose | Endpoint |
+|---|---|
+| Search | `https://api.wikimedia.org/core/v1/wikipedia/en/search/page?q=…&limit=10` |
+| Article summary | `https://en.wikipedia.org/api/rest_v1/page/summary/{title}` |
+
+The language path segment (`/en/`) is parameterised in `WikipediaService` for future multi-language support.
+
+## Original version
+
+The pre-modernization state (Swift 4 / iOS 11 / Carthage / UIKit, last commit 2018-10-10) is preserved at tag `v1.0-legacy`.

WikiMessage MessagesExtension/App/AppModel.swift

@@ -0,0 +1,8 @@
+import Combine
+import Messages
+
+final class AppModel: ObservableObject {
+    @Published var presentationStyle: MSMessagesAppPresentationStyle = .compact
+    @Published var composer: (any MessageComposer)?
+    @Published var selectedArticleURL: URL?
+}

WikiMessage MessagesExtension/App/RootView.swift

@@ -0,0 +1,19 @@
+import SwiftUI
+
+struct RootView: View {
+    @EnvironmentObject private var appModel: AppModel
+    @EnvironmentObject private var searchModel: SearchModel
+
+    var body: some View {
+        SearchResultsList()
+            .sheet(isPresented: Binding(
+                get: { appModel.selectedArticleURL != nil },
+                set: { if !$0 { appModel.selectedArticleURL = nil } }
+            )) {
+                if let url = appModel.selectedArticleURL {
+                    SafariView(url: url)
+                        .ignoresSafeArea()
+                }
+            }
+    }
+}