Repository navigation
feat: selective-install closure via .skills-deps.json - #17
Merged
Merged
Conversation
npx/adlc-cli --skill X installs exactly X — borrowers referencing a canonical helper in another skill broke silently under selective install (no installer resolves closures, and no home is install-guaranteed). - events.mjs: fetchSkillsDeps(source) (local/URL/shorthand/bare-dir, same source handling as fetchEventsManifest) + expandSkillSelection() (BFS transitive closure, cycle-safe, fail-open to the plain selection) - commands/skills.mjs: cmdAdd + cmdUpdate --pull expand the filter and pass repeated --skill flags to npx (verified array-capable); own command-generation filter follows the expanded set - Tests: 10 cases (fetch local/missing/malformed, direct/transitive/ cyclic/unknown/missing/* /array selections) - README: --skill flag documents closure expansion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selective
--skill Xinstalls exactly X — borrowers referencing a canonical helper in another skill broke silently (no installer resolves closures and no skill home is install-guaranteed).fetchSkillsDeps+expandSkillSelection(BFS, cycle-safe, fail-open) in events.mjscmdAdd+cmdUpdate --pullexpand the selection and pass repeated--skillflags to npx; own command generation follows the expanded set--skilldocs.skills-deps.json(PR #40)