Repository navigation
fix: derive version from package.json (hard-coded 2.0.0 shipped in v2.1.0) - #16
Merged
Merged
Conversation
…2.1.0 adlc-cli version printed the stale hard-coded constant instead of the real package version. Read package.json via createRequire (src/ → ../package.json, works in-repo and installed) and pin the contract with a drift-regression test that spawns the bin and asserts against package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
adlc-cli versionprinted2.0.0—src/dispatch.mjs:19hard-coded the constant and was missed in the v2.1.0 bump. Published npm package reports the wrong version.Fix
src/dispatch.mjs: read version from../package.jsonviacreateRequire(works in-repo and installed; zero deps)tests/bins.test.mjs: drift-regression test — spawn the bin, assert output equals package.json versionVerification
Followed by release v2.1.1.