fix(compression): copy sequence header properly for AV1 packet - #41
Open
manato wants to merge 1 commit into
Open
fix(compression): copy sequence header properly for AV1 packet#41manato wants to merge 1 commit into
manato wants to merge 1 commit into
Conversation
Previously, the `JetsonAV1Compressor` copied whole the first frame to every key frames to make generated stream decodable from any key frames. If the stream is processed a "spec-faithful" dedcoder, it generates blank images for every key frames (, and packing two key frames into one packet viorates the AV1 specification). This commit extracts only portion of information and copies it to every key frames to secure the specification and make the generated stream decodable from any key frames. Signed-off-by: Manato HIRABAYASHI <manato.hirabayashi@tier4.jp>
manato
marked this pull request as ready for review
September 3, 2026 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
N/A
Description
This PR fixes how to generate the necessary header information for AV1 keyframes.
Previously, the
JetsonAV1Compressorcopied the whole first frame to every key frame to make the generated streeam decodable from any key frame.If the stream is processed by a "spec-faithful" decoder, it generates a blank image for every key frame (, and packing two key frames into one packet, which violates the AV1 specification).
This PR extracts only a portion of information (called "Sequence Header") and copies it to every key frame to secure the specification and make the generated stream decodable from any key frame.
Review Procedure
Execute the followings on a Jetson platform
And visualize compressed data using AV1-compatible lichtblick (which is making in progress): TIER IV INTERNAL
In the previous implementation, blank frames (whole-green images) appear periodically.
After this PR is introduced, they should be gone.
acc_pr41_before.mp4
acc_pr41_after.mp4
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks
Stack created with GitHub Stacks CLI • Give Feedback 💬