Repository navigation
Print the whole abroad addresses report through a pipe - #285
Merged
Merged
Conversation
process.exit() right after console.log cut the JSON report off when stdout was a pipe, as when the CLI runs over ssh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #284.
npm run sections:update-abroad-addressescalledprocess.exit()right afterconsole.log, which cut off the JSON report when stdout is a pipe (seen when running the staging load over ssh: the summary on stderr was fine, the JSON stopped mid-string). It now setsprocess.exitCode. Checked locally: a 3000-row dry run prints the complete JSON through a pipe.