Repository navigation
Match abroad section ids with a non-zero 6th digit - #281
Merged
Merged
Conversation
CIK's 2026 abroad ids use 0, 1 or 2 in the 6th position (320012001, 320291132). SECTION_SEGMENT_BREAKDOWN only allowed 0 there, so GET /sections/:id, /results/:segment.json and the violations feed failed for 512 of the 613 abroad sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIK's 2026 abroad ids use 0, 1 or 2 in the 6th position (
320012001,320902332).SECTION_SEGMENT_BREAKDOWNonly allowed0there, soGET /sections/:id,/results/:segment.jsonand the violations feed answered 404 for 512 of the 613 abroad sections. Todayhttps://api.tibroish.bg/results/320902332.jsonis a 404 while/results/320010003.jsonworks.This is commit 3595594 from #272 on its own, so it can ship before the rest of #272.
src/sections/sections-pattern.ts: any digit in the 6th position of an abroad idsrc/sections/sections-pattern.spec.ts: full abroad ids with 0/1/2 there, abroad region/country segments, a domestic idnpm test(39 passed) and eslint are clean.