Repository navigation
Allow setting a violation section in any town - #280
Merged
Merged
Conversation
Admins need to fix signals sent for the wrong town too. Any existing section is accepted and the violation's town follows it; the section history entry now also records the previous and new town (code and name).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested for election day: admins must be able to move a signal to a section in another town.
PUT /violations/:id/sectionno longer requires the same town/municipality; any existing section is accepted andviolation.townbecomes the section's town.sectionhistory entry payload is now{ from, to, fromTown: { code, name }, toTown: { code, name } }.VIOLATION_SECTION_INVALID_FORMATfor non-9-digit input, 409VIOLATION_SECTION_NOT_FOUNDfor a nonexistent section, same permission as process/reject.VIOLATION_SECTION_IN_DIFFERENT_TOWNerror. Unit tests updated (other municipality, abroad).