Skip to content

Feat/integration tests - #39

Merged
jonathunne merged 15 commits into
tetherto:mainfrom
quocle108:feat/integration-tests
Oct 11, 2026
Merged

jonathunne merged 15 commits into
tetherto:mainfrom
quocle108:feat/integration-tests

Conversation

@quocle108

@quocle108 quocle108 commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Description

This PR is dependent on #38, we need it merge it first

Integration testsI: 222 tests across 8 suites that spawn the real bin/wdk.mjs against a throwaway config directory.

suite commands also covers
wallet create, import, unlock (+ session ttl), lock, export, list, default, rename, delete, change-passphrase a session when a module is disabled; the passphrase gate itself
network list, create, info, enable, disable, delete networks hidden by a disabled module; passphrase gate
token list, info, add, delete, enable, disable a hand-edited registry; a token a command has to resolve; a disabled token through network and module cycles; passphrase gate
module list, add, remove, enable, disable, methods passphrase gate
provider list, info, add, enable, disable, delete single-instance kinds; a provider hidden by a disabled module; provider config through a module cycle; a user-added provider in use; passphrase gate
config path, get, set, reset file permissions; passphrase gate; the wallet lock a config change forces
read-operations get address, message verify deriving on a network whose module is disabled
write-operations message sign, send, swap, bridge, buy, sell no provider for the kind; choosing the provider with --provider

Fixes

  • Deleting a provider left its config behind. Because you can reuse the name, the next provider added under it picked up the old settings
  • Split WalletDaemon.shutdown() into close() + exit, so a caller that owns the process can release resources without terminating.
  • config.json is now written 0600 and its directory 0700 since It holds provider API keys;

Motivation and Context

Related Issue

Closes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

@socket-security

socket-security Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@quocle108
quocle108 force-pushed the feat/integration-tests branch from fe5f590 to dd5fe5c Compare September 29, 2026 09:18
@quocle108 quocle108 changed the title WIP Feat/integration tests Feat/integration tests Sep 29, 2026
@quocle108 quocle108 self-assigned this Sep 29, 2026
@quocle108
quocle108 force-pushed the feat/integration-tests branch from 3af5049 to f916803 Compare October 8, 2026 00:40
jonathunne
jonathunne previously approved these changes Oct 8, 2026

@jonathunne jonathunne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quocle108
quocle108 dismissed jonathunne’s stale review October 10, 2026 21:51

The merge-base changed after approval.

@quocle108 quocle108 added the enhancement New feature or request label Oct 11, 2026
@quocle108
quocle108 force-pushed the feat/integration-tests branch from 6e69870 to c4a7517 Compare October 11, 2026 01:56
@quocle108
quocle108 force-pushed the feat/integration-tests branch from c4a7517 to ce805b7 Compare October 11, 2026 02:16
@jonathunne
jonathunne merged commit 067b707 into tetherto:main Oct 11, 2026
5 checks passed
@jonathunne jonathunne mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants