fix: make webhook cert Secret name configurable - #574
Open
niyomukiza-mechack wants to merge 1 commit into
Open
Conversation
niyomukiza-mechack
requested review from
a team,
eniko-dif and
jlegrone
as code owners
September 8, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Replaced the hard-coded webhook-server-cert Secret name with a new configurable Helm value
webhook.certSecretName. Previously, the Secret name was hard coded in bothtemplates/manager.yamlandtemplates/certmanager.yamlso users who bring their own TLS certificate had to name their Secret exactlywebhook-server-certno other name worked. Now they can setwebhook.certSecretNameto match whatever Secret they've created. The default is stillwebhook-server-certso existing installations are unaffected.Files changed:
values.yaml- addedwebhook.certSecretNamewith default value updated the caBundle comment to reference the value instead of the literal nametemplates/manager.yaml- replaced hard coded secretName:webhook-server-certwith{{ .Values.webhook.certSecretName }}templates/certmanager.yaml- same replacementvalues.schema.json- added certSecretName property to the webhook schemaWhy?
Context: #316
The webhook cert Secret name was hard coded as webhook-server-cert in two template files with no way to configure it. This caused a poor user experience: users who set
certmanager.enabled: falseand brought their own TLS certificate were forced to name their Secret exactlywebhook-server-certor the controller pod would get stuck in ContainerCreating forever. This is part of the larger webhook configuration cleanup tracked in #316.Checklist
Closes
How was this tested:
Verified the new value flows through to both templates
Custom Secret name renders in both manager.yaml and certmanager.yaml and Default value preserves backward compatibility