Conversation
Contributor
|
bugbot run |
1 similar comment
Contributor
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit cd967cf. Configure here.
yuandrew
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified the Link Converter code - modelling what was done for Java and bringing into the other SDKs:
temporalio/sdk-java#3068
There are multiple encoding and decoding methods for links, all pretty close but not quite. That had me worried as it is easy for them to get out of sync. This PR merges those methods.
ConvertWorkflowLinkToNexusLink was experimental and unused, and has been removed. It emitted a workflow-event path (/history) that could not be decoded as a Link_Workflow. Use ConvertLinkWorkflowToNexusLink instead.
Note
Medium Risk
Link URL shape affects interoperability; the deprecated
ConvertWorkflowLinkToNexusLinknow emits a different (correct) path, which could surprise any caller that depended on the old/historyURLs.Overview
Refactors
temporalnexuslink conversion so workflow event, workflow, Nexus operation, and activity variants share onelinkTypetable with sharedencode/decode(path templates, regex, proto type names) instead of four parallel URL builders and parsers.ConvertWorkflowLinkToNexusLinkis deprecated and now delegates toConvertLinkWorkflowToNexusLink, fixing output that incorrectly used a workflow-event path (…/history) and could not round-trip asLink_Workflow. Per-type public APIs andCommonLinkToNexusLink/NexusLinkToCommonLinkdispatch are unchanged in intent; workflow-event query handling is only reorganized.Tests add coverage for the deprecated helper fix and a shared path-ID escaping round-trip across all link kinds.
Reviewed by Cursor Bugbot for commit cd967cf. Bugbot is set up for automated code reviews on this repo. Configure here.