Conversation
When `CONFIG.USE_SHIPPING_PRICE` is enabled, the UI card price correctly included shipping costs. However, the background fetch for historic price points (`fetchPriceTimeSeries`) was hardcoded to only pull `data[0]` (the product-only price). This mismatch caused the script to compare a shipping-inclusive current price against a product-only historic low, resulting in false-positive "Aufschlag" (markup) calculations and badges. This commit updates `fetchPriceTimeSeries` to dynamically extract `data[1]` (the shipping-inclusive historic price) if the configuration is enabled, resolving the false markup calculation. Co-authored-by: tazztone <62671577+tazztone@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue where Toppreise cards displayed an "Aufschlag" badge when the current price was actually an all-time low. This occurred because the script was comparing shipping-inclusive card prices against product-only historic price trends.
PR created automatically by Jules for task 8265079700526443530 started by @tazztone