Repository navigation
Release through the reusable workflows of tamada/.github - #48
Merged
Merged
Conversation
The publish workflow did the tagging, the release, and the site deployment by itself. Hand them to the reusable workflows, and keep here what only this repository knows; building the command for each platform, and publishing the crate. - release-start tags main and opens the release as a draft, - build-hugo-and-publish builds docs and deploys it to Pages, and - release-finish takes the draft off with the token of the GitHub App. The draft matters. The assets are attached while nobody knows about the release, and the last job publishes it, which fires `release: published`; the release published by GITHUB_TOKEN, as the old workflow did, fires nothing. That is why notify-publish.yaml has never run once, and it will from now on. The site deployment was broken in a quiet way. The Pages of this repository serves what a workflow uploads (build_type: workflow), while the workflow pushed the built site to the gh-pages branch; the job succeeded, the branch moved, and Pages served the older site. It still tells v2.0.5 today, after the release of v3.0.0. build-hugo-and-publish uploads the artifact to Pages, hence, the deployment reaches the site. Also quiet the shellcheck of versionup.yaml; the redirections were unquoted, and it read a header into a variable which nothing used. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow tagged, released, and deployed the site by itself. This
hands those to the reusable workflows of
tamada/.github@v1, and keeps herewhat only this repository knows.
startrelease-start.yaml@v1— tags main, opens the release as a draftdocumentsbuild-hugo-and-publish.yaml@v1— buildsdocs, deploys to Pagespublishpublish_to_crates_iofinishrelease-finish.yaml@v1— publishes the draft with the App tokenTwo things this fixes
The site deployment was broken, quietly. Pages of this repository serves what a
workflow uploads (
build_type: workflow), while the workflow pushed the built site tothe
gh-pagesbranch. The job succeeded, the branch moved, and Pages kept serving theolder site; it still tells
v2.0.5today, after v3.0.0 was released. The last Pagesdeployment is of 2026-07-25.
notify-publish.yamlhas never run. A release published byGITHUB_TOKENdoes notfire
release: published.release-finishpublishes the draft with the token of theGitHub App, which does fire it.
Before merging: one secret is needed
release-finishreadsAPP_CLIENT_IDandAPP_PRIVATE_KEYthroughsecrets: inherit.This repository has
APP_PRIVATE_KEYandCLIENT_ID, which does not match by nameand therefore never arrives.
Add
APP_CLIENT_IDwith the same value asCLIENT_ID(or rename it, and updatenotify-publish.yamlwhich readsCLIENT_ID).Without it the release is still published, using
GITHUB_TOKEN, and the job says so inits log — but
notify-publishwould stay silent as before.Notes
versionas its input, so a release which failedhalfway is completed without merging a pull request again.
0.154.5; the blowfish theme ofdocs/go.modasks for 0.141.0or later and tells it works up to 0.154.5.
actionlintreports two findings onnotify-publish.yaml, both false: its bundledmetadata for
actions/create-github-app-token@v3is stale, and the upstream actiondoes accept
client-id. The reusablerelease-finishuses the same input.gh-pagesbranch is left as it is; nothing serves from it any more.🤖 Generated with Claude Code