Repository navigation
Conversation
Fragments stay accepted unless Config::check_document is set. With the check on, a second top-level element, character data outside the element, or end of input with no element is ill-formed. Refs tafia#848
Collaborator
|
I prefer that such check would be performed by the quick-xml consumers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One slice of #848: a document has exactly one element.
Config::check_documentstays off, so<a/><b/>and other fragments still parse. With the flag on, the reader returnsError::IllFormedfor:Comments and processing instructions around the element stay allowed.
enable_all_checksstill covers only the comment and end-name checks, so existing fragment callers are unchanged.The rest of #848 is still open. This does not try to close it.
Test plan
cargo test --all-features --lib --testsConfig::check_documentcargo fmt -- --check