Repository navigation
feat: allow comments in json transforms - #1381
Open
manuel3108 wants to merge 4 commits into
Open
manuel3108 wants to merge 4 commits into
manuel3108 wants to merge 4 commits into
Conversation
|
Install the latest version of pnx https://pkg.svelte.dev/sv/c/e9a258d67b94fb01c8fabbc1d2259e265b25e5fa createOpen in |
🦋 Changeset detectedLatest commit: e9a258d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
CI is failing here because of #1377, so that's expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1367
Description
We previously used
silver-fleecefor this. Thestringifyapi we were using drops comments. There is also apatchfunction in that same package, but it has major problems with dropping new lines and if entries are re-ordered.Therefore we will be switching to
comment-jsonwhich works as expected out of the box.Checklist