Skip to content

feat: allow comments in json transforms - #1381

Open
manuel3108 wants to merge 4 commits into
mainfrom
feat/allow-json-comments
Open

manuel3108 wants to merge 4 commits into
mainfrom
feat/allow-json-comments

Conversation

@manuel3108

Copy link
Copy Markdown
Member

Closes #1367

Description

We previously used silver-fleece for this. The stringify api we were using drops comments. There is also a patch function in that same package, but it has major problems with dropping new lines and if entries are re-ordered.

Therefore we will be switching to comment-json which works as expected out of the box.

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@pkg-svelte-dev

pkg-svelte-dev Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Install the latest version of sv from e9a258d:

pnx https://pkg.svelte.dev/sv/c/e9a258d67b94fb01c8fabbc1d2259e265b25e5fa create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1381

@changeset-bot

changeset-bot Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e9a258d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/sv-utils Minor
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manuel3108 manuel3108 added the needs-addon-integration-tests Run the addon integration test suite label Oct 2, 2026
@svelte-docs-bot

Copy link
Copy Markdown

@manuel3108

Copy link
Copy Markdown
Member Author

CI is failing here because of #1377, so that's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-addon-integration-tests Run the addon integration test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

migrate sveltekit-3: comments in tsconfig.json are removed

1 participant