Skip to content

use activerecord-imports "import"-method - #67

Open
aiomaster wants to merge 1 commit into
sunitparekh:masterfrom
webit-de:master
Open

aiomaster wants to merge 1 commit into
sunitparekh:masterfrom
webit-de:master

Conversation

@aiomaster

Copy link
Copy Markdown

See #66
I know that there are tests missing for the bulk_processing, cause we would need postgresql or mysql in the tests plus the activerecord-import gem (as development_dependency?) and I don't know how a good setup of these things should be done.
I tested the code with my production databases and it works very well.
If ::ActiveRecord::Import is not defined or bulk_processing is explicitly turned off by setting bulk_process false at the table definition than nothing changes.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 93.245% when pulling eee4c5e on webit-de:master into 6ccfda4 on sunitparekh:master.

3 similar comments
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 93.245% when pulling eee4c5e on webit-de:master into 6ccfda4 on sunitparekh:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 93.245% when pulling eee4c5e on webit-de:master into 6ccfda4 on sunitparekh:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.6%) to 93.245% when pulling eee4c5e on webit-de:master into 6ccfda4 on sunitparekh:master.

@wasabigeek

Copy link
Copy Markdown

+1

Comment thread lib/strategy/whitelist.rb Outdated
@aiomaster
aiomaster force-pushed the master branch 5 times, most recently from 4f823ed to 98a6d67 Compare October 16, 2019 13:38
@aiomaster
aiomaster force-pushed the master branch 2 times, most recently from 98a6d67 to 98a1713 Compare October 28, 2019 17:41
@aiomaster

Copy link
Copy Markdown
Author

Hey @sunitparekh,

is there anything I can do, to get this stuff in?

Thanks!

@sunitparekh

sunitparekh commented Oct 29, 2019 via email

Copy link
Copy Markdown
Owner

@aiomaster

Copy link
Copy Markdown
Author

send pull request

Hi @sunitparekh,

I thought this is a pull request or did I miss something?

Thanks

@sunitparekh

Copy link
Copy Markdown
Owner

let me rethink about bulk_import.... I need more time to write it with unit tests...

meanwhile if you are looking at more performant library of data-anon, please give it a try to https://github.com/dataanon/data-anon (Kotiln/Java version with high performant and batch support)

@stevereinke

Copy link
Copy Markdown

Hi there.
I would like to use this feature. Is the any progress on this issue?
Kind regards

@stevereinke

Copy link
Copy Markdown

Hi there.
Some years are gone, so is there any progress for this pull request?
Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants