docs: rename PR template anti-slop pass to quality pass

[mberrys]

What changed

Renames the PR template's "Anti-slop pass" section to Quality pass, and its "Anti-slop summary (1-3 sentences)" line to Quality summary (1-3 sentences). The six checklist items and the prompt comment are unchanged. The policy handoff wording now asks for a "quality summary" to match. The change is in agent-policy.json, and AGENTS.md, .claude/policy-brief.md and .cursor/agent-policy.md were regenerated with scripts/agent/generate-adapters.py --write. The change_review.anti_slop key in agent-policy.json and docs/schemas/agent-policy.schema.json is deliberately left as is, so the policy schema contract doesn't change. No issue.

Release changelog

Topic fragment: changes/cc-pr-template-quality-pass.md (Category: internal).

Proof

• python scripts/agent/check-change.py --base origin/dev reports pass (no C++ touched, so no build dir needed)
• One changes/<sanitized-head-branch>.md fragment added (Category, Audience, Breaking-Change, Summary), plus changes/cc-pr-template-quality-pass.evidence.yaml
• Changed behaviour has a test that fails without the change: scripts/agent/test_generate_adapters.py (5 tests) and scripts/agent/test_architecture_contracts.py (8 tests) pass. The adapter-currency check fails if AGENTS.md and the briefs drift from agent-policy.json.
• Protected-path or contract change named above: none (the schema key is unchanged)

Internal logic (touched behavior-bearing code)

• Guard clauses handle invalid, stale, cancelled, absent, unauthorized, and terminal cases before the happy path: N/A, text only
• Untrusted input is parsed once at the boundary into trusted typed or domain state, with no repeated checks downstream: N/A
• Invalid state stops before partial mutation or publication and returns a descriptive error or result: N/A
• Names carry the domain intent, and comments explain rationale rather than restating the code

Quality pass

• Redundant or explanatory comments that do not match the file's style removed
• Abnormal defensive checks and broad try/catch blocks removed where a trusted upstream boundary already guarantees the invariant, with real boundary and safety checks kept
• No any or equivalent cast added only to suppress a type error
• Python imports stay at file scope unless a local import is required
• Generated boilerplate, needless wrappers, and local-style drift removed
• Validation, security, cancellation, provenance, and failure handling preserved

Quality summary (1-3 sentences):

Wording-only rename. The regenerator also rewrote docs/branch-policy.json with identical content and only line-ending changes; that rewrite was discarded rather than committed.

Security and rollback

• Untrusted input validated at the trust boundary; no new unsafe construct without an inline justification
• Rollback: revert the three commits.

Docs

• Docs updated in this PR (template and generated policy adapters)

Self-review (BSP-002 §4.3)

• Reviewed in the diff view, not the editor, at least 30 minutes after the final commit; overnight if the change touches security-sensitive code, data handling, or public API surface

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}