L01-03: fence scheduled and worker results - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
Change
Proof
d297f8e5680ef71a7ba6c9c5e04a1040a337b258(basedc9ea93a1379ff4233f86059cd297b29c5962fda).ctest --test-dir build -C Release --output-on-failure -R "^(UnitTestsJobScheduler|UnitTestsRevisionStress|UnitTestsRepairDiff|UnitTestsPageSurface|UnitTestsDocumentFacade|UnitTestsPreflightInteraction|UnitTestsViewportCommands|UnitTestsEditorHost)$"— 8/8 passed.document-1/revision-1scheduler jobs, syntheticdoc-1page surfaces, and the DocumentFacade fake loader. They cover timeout, retry, cancel, reopen, out-of-order completion, mismatched render identity, and worker success followed by scheduler failure; no external fixture artifact was used.scripts/agent/check-architecture.py --base dc9ea93a1379ff4233f86059cd297b29c5962fda --head-branch codex/issue-17-fence-scheduled-results— passed.scripts/agent/check-change.py --base dc9ea93a1379ff4233f86059cd297b29c5962fda --build-dir buildran the mapped Release lane: all builds and 74/74 tests passed. Its overall result is not a pass. The format check exposed mixed line endings in the cancellation fixture; these were normalized without a source-content change, and a directclang-format --dry-run --Werrorrerun passed. The Visual Studio build lacked a compile database, leaving the gate's clang-tidy lane incomplete. A Ninja compilation database allowed a separate clang-tidy run onpdfjobscheduler.cppto finish with exit 0 and warnings; a full gate rerun was stopped after clang-tidy spent over twelve minutes oneditorhost.cppwithout reaching the other changed files.agent-fast / build, fuzz, CodeQL, Semgrep, policy, architecture, source integrity, package scripts, and language analyses. Thewindowsandlinuxjobs were skipped by workflow rules.Remaining risk
The timer-based admission handoff relies on the scheduler reaching a terminal snapshot after a worker returns. Its failure path rejects absent or unsuccessful snapshots. Independent release qualification and other platforms remain governed by the existing proof lanes.
Anti-slop review
Reviewed the touched diff for redundant checks, comments, and wrappers. Kept only boundary checks that bind terminal status and request identity; removed an outdated revision-fence comment and a duplicate include.